Implement auto-deletion and protection for branches #265
+1,174
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement auto-deletion modes and deletion protection for branches and
snapshots, similar to existing clone features:
- Add AutoDeleteMode type with three modes:
- Off (0): auto-deletion disabled
- Soft (1): auto-delete only if no dependencies
- Force (2): auto-delete with recursive destroy
- Update models (Branch, Snapshot, Clone) with:
- Protected: boolean to prevent deletion
- DeleteAt: scheduled deletion timestamp
- AutoDeleteMode: auto-deletion behavior
- Add API endpoints:
- PATCH /branch/{branchName}: update branch metadata
- PATCH /snapshot/{id}: update snapshot metadata
- Add protection checks to delete operations:
- Branches cannot be deleted if protected
- Snapshots cannot be deleted if protected
- Add background auto-deletion job that:
- Checks for expired clones, branches, and snapshots
- Respects auto-delete mode when handling dependencies
- Force mode deletes dependent entities recursively
- Soft mode skips if dependencies exist
- Add entity storage for persisting branch/snapshot metadata
- Fix LocalTime conversion in base.go and entity_storage.go (use .Time field) - Fix CLI actions.go to use pointer for Protected field - Fix routes.go to use updatedClone.Protected for telemetry event - Add thinclones import and DestroyOptions parameter in auto_delete.go - Fix clone_test.go to handle Protected pointer properly
- Break long function signatures into multiple lines (base.go, entity_storage.go) - Fix wsl issues by adding blank lines before if statements - Pre-allocate slices in canDeleteSnapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement auto-deletion modes and deletion protection for branches and snapshots, similar to existing clone features:
Add AutoDeleteMode type with three modes:
Update models (Branch, Snapshot, Clone) with:
Add API endpoints:
Add protection checks to delete operations:
Add background auto-deletion job that:
Add entity storage for persisting branch/snapshot metadata