Skip to content

Fix _postman_previewlanguage construction during syncCollection#938

Merged
animeshjajoopostman merged 1 commit intodevelopfrom
fix/response-preview-lang
Apr 14, 2026
Merged

Fix _postman_previewlanguage construction during syncCollection#938
animeshjajoopostman merged 1 commit intodevelopfrom
fix/response-preview-lang

Conversation

@animeshjajoopostman
Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

integration test code coverage

Lines Statements Branches Functions
Coverage: 19%
19.58% (2100/10723) 13.36% (999/7475) 20.77% (248/1194)
Coverage Breakdown • (19%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files19.5813.3620.7719.88 
report-only-changed-files is enabled. No files were changed in this commit :)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

unit test code coverage

Lines Statements Branches Functions
Coverage: 88%
88.83% (5873/6611) 80.56% (3860/4791) 94% (862/917)
Coverage Breakdown • (88%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files88.8380.569488.94 
report-only-changed-files is enabled. No files were changed in this commit :)


// SDK converts _postman_previewlanguage to { _: { postman_previewlanguage: '' } }
// during response construction.
const previewLanguage = (response as any)._postman_previewlanguage ??
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove these any coercisions ? @animeshjajoopostman

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The '_postman_previewlanguage' does not exist on the type defined by the collection sdk (Response)

status: 'OK',
code: 200,
_postman_previewlanguage: 'Text',
_postman_previewlanguage: 'text',
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this text verified from the exported collection

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this. The exported collection json has"_postman_previewlanguage": "text",

@animeshjajoopostman animeshjajoopostman marked this pull request as ready for review April 14, 2026 06:32
@animeshjajoopostman animeshjajoopostman merged commit ebe5511 into develop Apr 14, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants