Fix sync isolate retry loop due to single-subscription stream#401
Merged
Fix sync isolate retry loop due to single-subscription stream#401
Conversation
rkistner
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If, for whatever reason, we fail to instantiate a sync isolate on native platforms, we will retry automatically.
That's a sensible recovery strategy, but we use a single-subscription stream controller to notify the sync client about changed subscriptions. So on a reconnect, we'd attempt to subscribe again and get an immediate error because the stream has already been listened to.
This fixes the issue by using one controller per internal connect call. We can't use a broadcast stream controller since that would swallow events when no listeners are present, which is not what we want.
I've tested these changes manually by adding a random 70% crash chance in the sync isolate and started a demo app. We correctly respawn the isolate until that works now.
Closes #397.