Invert DrawNode application for composability#2314
Merged
peppy merged 20 commits intoppy:masterfrom Apr 25, 2019
Merged
Conversation
This stuff is very sprite-specific (inflation amount...).
This was referenced Apr 2, 2019
# Conflicts: # osu.Framework/Graphics/Audio/WaveformGraph.cs
8 tasks
# Conflicts: # osu.Framework/Graphics/Containers/BufferedContainerDrawNode.cs # osu.Framework/Graphics/Lines/PathDrawNode.cs
Contributor
Author
|
Blocking because this has broken volume meter. |
Member
|
On a first pass this is looking quite good to me. |
peppy
previously approved these changes
Apr 14, 2019
# Conflicts: # osu.Framework/Graphics/Audio/WaveformGraph.cs
peppy
approved these changes
Apr 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want
DrawNodes to be composable for use with a futureBufferedDrawNode.The end goal is for the following to be possible:
Which will basically draw the path into a framebuffer. This is not really well supported by
DrawNodes right now due toDrawable.ApplyDrawNode()requiring that you know the type ofDrawNodegiven byCreateDrawNode(), which is not always possible.Furthermore,
ApplyDrawNode()would also have to fill the state ofBufferedDrawNode.In this PR:
Drawable
- ApplyDrawNode(DrawNode node)The
ApplyDrawNode()method has been removed.DrawNode
The constructor provides the source from which the state for the
DrawNodeis copied.The
ApplyState()method serves the same purpose asApplyDrawNode(), except in reverse - copying states from the Drawable to ourselves.Breaking Changes
Drawable.ApplyDrawNode()has been removedThe direction of application of
DrawNodestates has been inversed.Previously:
Now:
The namespace of
EdgeEffectParametersandEdgeEffectTypehas changedThey now reside in
osu.Framework.Graphics.Effects.