Lazy init AudioAdjustments in AdjustableAudioComponent usage#5532
Merged
smoogipoo merged 2 commits intoppy:masterfrom Nov 22, 2022
Merged
Lazy init AudioAdjustments in AdjustableAudioComponent usage#5532smoogipoo merged 2 commits intoppy:masterfrom
AudioAdjustments in AdjustableAudioComponent usage#5532smoogipoo merged 2 commits intoppy:masterfrom
Conversation
smoogipoo
approved these changes
Nov 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is beneficial due to the number of samples which are retrieves during BDL load but never played. In cases they aren't played the
Samples retrieved from aSampleFactorycan avoid theAudioAdjustmentsoverhead, which will now only be instantiated when they are played (seeosu-framework/osu.Framework/Audio/Sample/SampleBassFactory.cs
Lines 100 to 105 in 32e7571
Logging can be performed using this adjustment:
At song select:
Before:
After:
Note that there are other potential areas that could also fix this (ie. stopping every single instance of
HoverClickSoundsfrom fetching its own samples osu! side) but I feel this is beneficial to also optimise at a lower level, since retrieving samples from aSampleStorefor (potential) future use is a common one.