Skip to content

Conversation

@minetoblend
Copy link
Contributor

Adds the new background based on @vatei's designs.
Note that the colors might be a tiny bit off, did so to be able to use the OverlayColourProvider.

This also replaces the background for all matchmaking test scenes via the new MatchmakingTestScene class.
exceptions are the Queue-Screen related test scenes & TestSceneMatchmakingScreen since it should create the background itself.

image

@peppy peppy self-requested a review November 21, 2025 04:38
@peppy
Copy link
Member

peppy commented Nov 21, 2025

osu! 2025-11-21 at 04 53 43

Is this how it's supposed to look? Note that this means it will no longer display the active beatmap. Not sure if that is the intention.

Also, your PR crashes in gameplay. I've committed a fix but still unsure about direction. We're just reusing an old generic background after all.

@peppy peppy force-pushed the feature/matchmaking-bg branch from edf1a2e to 1dd026c Compare November 21, 2025 04:58
@peppy peppy changed the title Quickplay: implement new Background Quickplay: Update background image to match designs Nov 21, 2025
@peppy peppy added quick fix Tasks which were taken on because they take no time to fix area:quick-play and removed quick fix Tasks which were taken on because they take no time to fix labels Nov 21, 2025
@minetoblend
Copy link
Contributor Author

minetoblend commented Nov 21, 2025

Is this how it's supposed to look? Note that this means it will no longer display the active beatmap. Not sure if that is the intention.

The background behind the matchmaking screenstack would have to go sooner or later but without removing it looks like what I was expecting right now. Was planning that as a follow-up task (WIP image below) alongside the other layout changes.
image

About showing the active beatmap background, I was under the assumption that if it was shown it would only really make sense in the time between the beatmap pick/reveal and gameplay start? In that case it could only show after the beatmap has finished downloading which could look quite awkward if you're the last one to finish the download, since the background would switch to the map bg and then immediately after the gameplay screen starts which also uses the beatmap bg (but probably slightly different).
Vatei's designs also make quite heavy use of the pink accent colours in some places so I'm kinda worried about the colours potentially clashing if the beatmap background was visible in all places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants