Fix beatmap samples with incorrect 1 sample set suffix in the filename being shown in setup tab as belonging to custom sample bank 1#36425
Merged
peppy merged 1 commit intoppy:masterfrom Jan 22, 2026
Conversation
…e being shown in setup tab as belonging to custom sample bank 1 To explain on the wordy and probably incoherent title: The patient zero for this was the following discord report: https://discord.com/channels/188630481301012481/1097318920991559880/1463029073998774375 After information extraction, it turned out that the user manually used the "Edit externally..." feature to rename a sample to `normal-hitnormal1.mp3`, thinking (logically, to be fair), that the 1 bank works the same way that all the others do. It doesn't, samples in the 1 bank do not have a numerical suffix in the filename - but the logic retrieving the sample sets to display in the setup tab was not checking that, leading to confusion wherein a sample would only "work" in the setup tab but not in the actual editor composer. Can be tested with the beatmap provided by the user: https://discord.com/channels/188630481301012481/1097318920991559880/1463110516573470774
bdach
added
area:editor
quick fix
peppy
approved these changes
Jan 22, 2026
github-project-automation
bot
moved this from Pending Review
to Done
in osu! team task tracker
This was referenced Jan 28, 2026
This was referenced Feb 9, 2026
This was referenced Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To explain on the wordy and probably incoherent title: The patient zero for this was the following discord report: https://discord.com/channels/188630481301012481/1097318920991559880/1463029073998774375
After information extraction, it turned out that the user manually used the "Edit externally..." feature to rename a sample to
normal-hitnormal1.mp3, thinking (logically, to be fair), that the 1 bank works the same way that all the others do.It doesn't, samples in the 1 bank do not have a numerical suffix in the filename - but the logic retrieving the sample sets to display in the setup tab was not checking that, leading to confusion wherein a sample would only "work" in the setup tab but not in the actual editor composer.
Can be tested with the beatmap provided by the user.