Skip to content

♻️ (fish) use eza in fish as well , removes lsd#1496

Merged
kRHYME7 merged 9 commits intoprasanthrangan:mainfrom
rubiin:fish
Aug 29, 2024
Merged

♻️ (fish) use eza in fish as well , removes lsd#1496
kRHYME7 merged 9 commits intoprasanthrangan:mainfrom
rubiin:fish

Conversation

@rubiin
Copy link
Contributor

@rubiin rubiin commented May 13, 2024

Pull Request

As we are using eza for zsh and lsd for fish , it would be better to use eza for both as it saves us from trouble of maintaining configs for both

Description

Please read these instructions and remove unnecessary text.

  • Try to include a summary of the changes and which issue is fixed.
  • Also include relevant motivation and context (if applicable).
  • List any dependencies that are required for this change. (e.g., packages or other PRs)
  • Provide a link if there is an issue related to this pull request. e.g., Fixes # (issue)
  • Please add Reviewers, Assignees, Labels, Projects, and Milestones to the PR. (if applicable)

Type of change

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added a changelog entry.
  • I have added necessary comments/documentation to my code.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

Screenshots

Using eza on fish shell

image

(if appropriate)

Additional context

Add any other context about the problem here.

@kRHYME7
Copy link
Collaborator

kRHYME7 commented May 13, 2024

difference of both? I didnt care until now Lol.

@rubiin
Copy link
Contributor Author

rubiin commented May 13, 2024

difference of both? I didnt care until now Lol.

They are the same, replacement for ls . but eza is more feature rich

@rubiin
Copy link
Contributor Author

rubiin commented Jun 14, 2024

any updates on this

@abenezerw
Copy link
Contributor

makes sense i guess, he is just saying using eza for both fish and zsh would reduce the need for an additional lsd config since we are using lsd for fish.

@abenezerw
Copy link
Contributor

makes sense i guess, he is just saying using eza for both fish and zsh would reduce the need for an additional lsd config since we are using lsd for fish.

Was looking at an install of this hyprdots, and it actually mentions this in the install.
IMG_1328

@rubiin
Copy link
Contributor Author

rubiin commented Aug 28, 2024

@abenezerw thanks for mentioning that. I will push a fix. Seems I forgot to update a file

rubiin and others added 2 commits August 29, 2024 00:17
Fish configs should also act like zsh configs. We need to preserve user if the folder exist.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the lsd configs for now.

Make lsd optional
Copy link
Collaborator

@kRHYME7 kRHYME7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bring back the lsd configuration.

@rubiin rubiin requested a review from kRHYME7 August 29, 2024 08:36
Copy link
Collaborator

@kRHYME7 kRHYME7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🫶

@kRHYME7 kRHYME7 merged commit 7ee6cf1 into prasanthrangan:main Aug 29, 2024
@rubiin rubiin deleted the fish branch August 29, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants