♻️ (fish) use eza in fish as well , removes lsd#1496
Merged
kRHYME7 merged 9 commits intoprasanthrangan:mainfrom Aug 29, 2024
rubiin:fish
Merged
♻️ (fish) use eza in fish as well , removes lsd#1496kRHYME7 merged 9 commits intoprasanthrangan:mainfrom rubiin:fish
kRHYME7 merged 9 commits intoprasanthrangan:mainfrom
rubiin:fish
Conversation
Collaborator
|
difference of both? I didnt care until now Lol. |
Contributor
Author
They are the same, replacement for ls . but eza is more feature rich |
Contributor
Author
|
any updates on this |
Contributor
|
makes sense i guess, he is just saying using eza for both fish and zsh would reduce the need for an additional lsd config since we are using lsd for fish. |
Contributor
Contributor
Author
|
@abenezerw thanks for mentioning that. I will push a fix. Seems I forgot to update a file |
Fish configs should also act like zsh configs. We need to preserve user if the folder exist.
kRHYME7
reviewed
Aug 28, 2024
Collaborator
There was a problem hiding this comment.
Let's keep the lsd configs for now.
Make lsd optional
kRHYME7
requested changes
Aug 29, 2024
Collaborator
kRHYME7
left a comment
There was a problem hiding this comment.
Please bring back the lsd configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pull Request
As we are using
ezafor zsh andlsdfor fish , it would be better to useezafor both as it saves us from trouble of maintaining configs for bothDescription
Please read these instructions and remove unnecessary text.
Type of change
Please put an
xin the boxes that apply:Checklist
Please put an
xin the boxes that apply:Screenshots
Using
ezaon fish shell(if appropriate)
Additional context
Add any other context about the problem here.