fix: improve Flatpak installation script for better user interaction …#1793
Open
ShinniUwU wants to merge 1 commit intoprasanthrangan:mainfrom
Open
fix: improve Flatpak installation script for better user interaction …#1793ShinniUwU wants to merge 1 commit intoprasanthrangan:mainfrom
ShinniUwU wants to merge 1 commit intoprasanthrangan:mainfrom
Conversation
kRHYME7
approved these changes
Sep 1, 2024
Collaborator
kRHYME7
left a comment
There was a problem hiding this comment.
Will wait for others to approve this. I scanned through the script and it looks good to me.
Collaborator
|
@rubiin Have you tried running the script? |
Contributor
|
Nah I just verified the code visually |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This pull request introduces improvements to the Flatpak installation script by adding user interaction features, such as a selection menu and confirmation prompts. These enhancements aim to provide a more user-friendly experience during the installation of Flatpak applications.
Summary of Changes
Motivation and Context
The previous script lacked user interaction and always installed all applications listed in the configuration file. The new script allows for more control over the installation process, making it more flexible and user-friendly.
Dependencies
global_fn.sh, specificallypkg_installed.Related Issues
N/A
Type of change
Please put an
xin the boxes that apply:Checklist
Please put an
xin the boxes that apply:Screenshots
N/A
Additional context