Conversation
asottile
force-pushed
the
mixed-line-ending
branch
from
d6bcb26 to
fbcd096
Compare
sjswerdloff
approved these changes
Dec 27, 2021
sjswerdloff
left a comment
sjswerdloff
left a comment
There was a problem hiding this comment.
Good idea.
Does this work when an entire file uses ?
Member
Author
|
you can easily find the answer by simply trying it out! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@nagromc - I squashed your commits, fixed the tests on windows, and applied my review feedback -- I managed to reimplement it in a (imo) much simpler way too!
This supersedes #218 and resolves #196