Guard the usage of localStorage to catch exceptions.#270
Merged
developit merged 2 commits intopreactjs:masterfrom Feb 14, 2019
molily:localstorage
Merged
Guard the usage of localStorage to catch exceptions.#270developit merged 2 commits intopreactjs:masterfrom molily:localstorage
developit merged 2 commits intopreactjs:masterfrom
molily:localstorage
Conversation
molily
commented
Feb 13, 2019
| let state; | ||
| try { | ||
| state = JSON.parse(localStorage.state); | ||
| state = JSON.parse(localStorageGet('state')); |
Contributor
Author
There was a problem hiding this comment.
This line is already wrapped in a try-catch, so it was safe already, but i’ve used localStorageGet here for consistency.
developit
approved these changes
Feb 14, 2019
Member
developit
left a comment
developit
left a comment
There was a problem hiding this comment.
Nice! This should apply equally to Safari in-private browsing too.
This was referenced Sep 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! I’ve configured my browser to block cookies unless allowed per domain. Access to localStorage throws an exception in this case. This blows up many web sites that render content using JS and do not guard the use of localStorage with a
try {} catch () {}. Including preactjs.com:This change introduces helper functions for accessing localStorage wrapped in try/catch.
Let me know if you find this useful.