Optimizing DoF filtering while extracting vertex data from FEniCS#135
Merged
BenjaminRodenberg merged 6 commits intodevelopfrom Jul 12, 2021
Merged
Optimizing DoF filtering while extracting vertex data from FEniCS#135BenjaminRodenberg merged 6 commits intodevelopfrom
BenjaminRodenberg merged 6 commits intodevelopfrom
Conversation
BenjaminRodenberg
suggested changes
Jul 8, 2021
Contributor
BenjaminRodenberg
left a comment
BenjaminRodenberg
left a comment
There was a problem hiding this comment.
This PR is a huge improvement w.r.t performance for large cases!
Mostly comments on documentation and design/style. I did a performance test with the partitioned heat equation with each participant on one node with 28 cores. I did not see any degradation comparing d6f5590 (3D version) and ba9c61d (this PR). I will do another check with the latest change to make sure I did not do something stupid in 30295ec.
BenjaminRodenberg
approved these changes
Jul 8, 2021
Contributor
BenjaminRodenberg
left a comment
BenjaminRodenberg
left a comment
There was a problem hiding this comment.
Just some smaller things.
I will do another round of performance checks with the final version and then merge.
Contributor
|
Performance overall looks good as it is. Will merge this PR now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the functions used to filter FEniCS DoFs for relevant vertex information for parallel computations. This refactoring was done as part of implementing 3D capability and was also tested on the LRZ Linux Cluster and found to reduce initialization time by a significant factor.