Offers more control to the user via new interface#59
Conversation
|
A usage example is provided in https://github.com/precice/tutorials/tree/introduceMidLevelInterface/HT/partitioned-heat/fenics-fenics-core |
IshaanDesai
changed the title
BenjaminRodenberg
left a comment
BenjaminRodenberg
left a comment
There was a problem hiding this comment.
As soon as the return value of the read function is fixed, I can take care of updating the tests.
BenjaminRodenberg
left a comment
BenjaminRodenberg
left a comment
There was a problem hiding this comment.
I mainly have comments on documentation. The rest looks good and is in my opinion ready to merge 👍
Feel free to go ahead, when you think everything is ready. Please stash the commits before you merge to avoid unnecessary commits in the history.
| :return: Returns lists of PointSources | ||
| """ | ||
| # PointSources are scalar valued, therefore we need an individual scalar valued PointSource for each dimension in a vector-valued setting | ||
| # TODO: a vector valued PointSource would be more straightforward, but does not exist (as far as I know) |
There was a problem hiding this comment.
I totally agree. I think we should create an issue for this todo.
|
I just realized that for checkpointing the From an API design point of view it would be less restrictive to make these parameters optional to not force the user to provide them, if they are not required for the case the user is solving or do not even exist. However, I think we can also solve this later. If a user really has a problem providing |
…ated tutorials (#62) Ensures compatibility of tutorials to new interface of FEniCS adapter introduced in precice/fenics-adapter#59
* introduces mid level interface #37 * Replacing all API functions to new python_bindings structure * Adapter Core now contains only helper functions. adapter_core.py is a source file where no API functions are present. * Changing the way boundary conditions are updated. Providing a generic function so that user can update boundary condition. * Saving a copy of all FEniCS functions passed to Adapter to ensure Adapter does not directly modify functions in the problem setup * New point source functions to handling vector point sources in FSI cases * Numpy docstring style documentation for all functions and classes * Fixing read and write mock tests * Adding mock test for FEniCS Expression functionality * Disabling Windows and OSx tests as fenics dependency not satisfied Co-authored-by: ishaandesai <ishaandesai@gmail.com>
4 participants
closes #37 and #33
Also closes #66 as the new design now has numpy docstring style documentation