Skip to content

Fixes #210#211

Merged
jonasvdd merged 10 commits intomainfrom
datetime_bugfix
May 12, 2023
Merged

Fixes #210#211
jonasvdd merged 10 commits intomainfrom
datetime_bugfix

Conversation

@jonasvdd
Copy link
Collaborator

@jonasvdd jonasvdd commented May 11, 2023

Fixes #210

@jonasvdd jonasvdd requested a review from jvdd May 11, 2023 13:50
@codecov-commenter
Copy link

codecov-commenter commented May 12, 2023

Codecov Report

Merging #211 (2cf6096) into main (e56cbc7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #211   +/-   ##
=======================================
  Coverage   97.15%   97.15%           
=======================================
  Files          13       13           
  Lines         983      985    +2     
=======================================
+ Hits          955      957    +2     
  Misses         28       28           
Impacted Files Coverage Δ
...ler/figure_resampler/figure_resampler_interface.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@jvdd jvdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonasvdd jonasvdd merged commit a14331e into main May 12, 2023
jonasvdd added a commit that referenced this pull request May 12, 2023
* 💪 add tests for #208

* 🙏 fix for #208

* ✨ tests for #210

* 💪 code-fix for #210

* 🔧 tests for setting hf_x dynamically for #210

* 🔥 fix for setting hf_series x to a tz-aware pd.Series

* 🖊️ review

* 🔍 review code

* 🔍 fix helper method

* 🙏

---------

Co-authored-by: jvdd <boebievdd@gmail.com>
jonasvdd added a commit that referenced this pull request May 14, 2023
* 🍌 formatting

* 💨 first version of log axis support

* 🙈 fix tests

* 🔧 adresses #190 and #205

* 🙈 formatting

* Datetime bugfix (#209)

* 💪 add tests for #208

* 🙏 fix for #208

* Fixes #210 (#211)

* 💪 add tests for #208

* 🙏 fix for #208

* ✨ tests for #210

* 💪 code-fix for #210

* 🔧 tests for setting hf_x dynamically for #210

* 🔥 fix for setting hf_series x to a tz-aware pd.Series

* 🖊️ review

* 🔍 review code

* 🔍 fix helper method

* 🙏

---------

Co-authored-by: jvdd <boebievdd@gmail.com>

* 🔍 review

* 🖊️ review code

* ✨ improve docs + add rangeindex log test

* 💨 fix test + add example

* 🔍 review code

---------

Co-authored-by: jvdd <boebievdd@gmail.com>
Co-authored-by: Jeroen Van Der Donckt <18898740+jvdd@users.noreply.github.com>
@jvdd jvdd deleted the datetime_bugfix branch June 18, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tz-aware datetime pd.Series. -> tz information gets lost

3 participants