Skip to content

🐛 convert trace props to array + check for nan removal#225

Merged
jonasvdd merged 5 commits intomainfrom
224-no-support-for-text-per-marker-or-color-per-marker
Jun 14, 2023
Merged

🐛 convert trace props to array + check for nan removal#225
jonasvdd merged 5 commits intomainfrom
224-no-support-for-text-per-marker-or-color-per-marker

Conversation

@jvdd
Copy link
Collaborator

@jvdd jvdd commented Jun 12, 2023

  • add tests for passing a tuple as hf property
  • remove nan values (i.e., values where hf_y is nan) from hf props + test this

@jvdd jvdd linked an issue Jun 12, 2023 that may be closed by this pull request
@jvdd jvdd changed the title 🐛 convert trace props to array if not np.ndarray 🐛 convert trace props to array + check for nan removal Jun 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2023

Codecov Report

Merging #225 (49b5310) into main (3ad5920) will decrease coverage by 0.08%.
The diff coverage is 90.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #225      +/-   ##
==========================================
- Coverage   97.19%   97.11%   -0.08%     
==========================================
  Files          13       13              
  Lines         998     1006       +8     
==========================================
+ Hits          970      977       +7     
- Misses         28       29       +1     
Impacted Files Coverage Δ
...ler/figure_resampler/figure_resampler_interface.py 99.74% <90.00%> (-0.26%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jvdd jvdd requested a review from jonasvdd June 13, 2023 12:33
Copy link
Collaborator

@jonasvdd jonasvdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM!

@jonasvdd jonasvdd merged commit 248fa83 into main Jun 14, 2023
@jvdd jvdd deleted the 224-no-support-for-text-per-marker-or-color-per-marker branch June 18, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No support for text-per-marker or color-per-marker

3 participants