Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
==========================================
- Coverage 96.46% 96.40% -0.06%
==========================================
Files 14 14
Lines 1130 1140 +10
==========================================
+ Hits 1090 1099 +9
- Misses 40 41 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Ready for review @jvdd! |
mhangaard
reviewed
Jan 19, 2024
| extra_layout_updates[f"{axis}.autorange"] = None | ||
| return extra_layout_updates | ||
|
|
||
| def construct_update_data( |
There was a problem hiding this comment.
Good work guys, be aware this changes the interface. When it's not backwards compatible it should be tagged with a major version bump if following Semantic Versioning. Congrats on 1.0.0 :D
There was a problem hiding this comment.
Would be nice to add this to the change log, with supporting documentation to use the new interface. This broke my code and I had to dig to find this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[BUG] Patch does not seem to work with
subplotssolved now!
Reproduce issue - clone this branch and run this code in a notebook.
Patch does not seem to properly work with subplots.
How I use patch to update a figure with subplots:
TODO:
seleniumclass to be compatible with patch type objects