feat(triage): implement patternMatchCount boost#30
Closed
TerminalGravity wants to merge 4 commits intomainfrom
Closed
feat(triage): implement patternMatchCount boost#30TerminalGravity wants to merge 4 commits intomainfrom
TerminalGravity wants to merge 4 commits intomainfrom
Conversation
… and contracts The README references .preflight/ config extensively but there were no concrete example files to copy. This adds a ready-to-use examples/.preflight/ directory with annotated config.yml, triage.yml, and contracts/api.yml, plus a README explaining how to use them.
- Add 17 tests covering config loading from .preflight/, env var overrides, caching, malformed YAML handling, and helper functions - Export resetConfig() to clear cached config (needed for tests and potential config hot-reload) - All 60 tests passing
…tests + fix dotfile bug - Extract extractFilePaths, detectAmbiguity, estimateComplexity, splitSubtasks into src/lib/preflight.ts - Add comprehensive test suite (tests/lib/preflight.test.ts) — 20 new tests - Fix bug: extractFilePaths now correctly detects dotfiles (.env, .gitignore) - preflight-check.ts imports from lib instead of inline definitions - All 80 tests pass
The TriageConfig.patternMatchCount field was declared in the interface and documented as 'boosts level to at least ambiguous' but never actually consumed by triagePrompt(). Now when patternMatchCount >= 2, prompts that would otherwise classify as 'clear' get bumped to 'ambiguous' with clarify-intent and scope-work recommended. This closes the loop between correction pattern learning (#13) and smart triage (#8) — if a prompt matches multiple known correction patterns, we proactively flag it before the agent wastes tokens. Added tests for both the boost case and the below-threshold case.
Collaborator
Author
|
Superseded by newer PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the config field that was declared but never used in
triagePrompt(). When >= 2 correction patterns match a prompt, it gets bumped fromclear→ambiguouswith clarify-intent/scope-work recommended.Connects correction pattern learning (#13) to smart triage (#8) — if we've seen this kind of prompt cause corrections before, we flag it proactively.
triagePrompt()(threshold: 2 pattern matches)