test: add 13 unit tests for preflight_check helpers#33
Closed
TerminalGravity wants to merge 4 commits intomainfrom
Closed
test: add 13 unit tests for preflight_check helpers#33TerminalGravity wants to merge 4 commits intomainfrom
TerminalGravity wants to merge 4 commits intomainfrom
Conversation
… and contracts The README references .preflight/ config extensively but there were no concrete example files to copy. This adds a ready-to-use examples/.preflight/ directory with annotated config.yml, triage.yml, and contracts/api.yml, plus a README explaining how to use them.
Created examples/USAGE_EXAMPLES.md with 8 real-world scenarios showing what each tool looks like in practice: preflight_check catching vague prompts, scope_work creating execution plans, enrich_agent_task for sub-agents, sharpen_followup resolving ambiguity, session health checks, semantic history search, weekly scorecards, and prompt grading. Added link to usage examples in README nav bar.
Export extractFilePaths, buildScopeSection, buildSequenceSection from preflight-check.ts and add comprehensive tests covering: - File path extraction (dedup, dotfiles, various extensions) - Scope estimation (SMALL/MEDIUM/LARGE based on file count + dir spread) - Sequence splitting (multi-step parsing, risk classification, checkpoints) Takes test count from 43 → 56.
TerminalGravity
commented
Feb 28, 2026
Collaborator
Author
TerminalGravity
left a comment
TerminalGravity
left a comment
There was a problem hiding this comment.
Tests look good. Noticed this PR also bundles the example configs and README changes from #34 — if #34 lands first you'll want to rebase.
The unused import cleanup overlaps with #32 too. These PRs have a lot of cross-contamination — might be worth doing a quick rebase pass to isolate each PR's scope. Otherwise reviewers can't tell what's unique to each branch.
The actual test additions are solid though. 👍
Collaborator
Author
|
Superseded by newer PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exports and tests the core helper functions in
preflight-check.ts:extractFilePaths— file path extraction from prompt text (dedup, dotfiles, various extensions)buildScopeSection— scope estimation (SMALL/MEDIUM/LARGE based on file count + directory spread)buildSequenceSection— multi-step parsing, risk classification (HIGH/MEDIUM/LOW), checkpoint remindersTakes test count from 43 → 56. All passing.