test: add 20 tests for preflight_check triage integration#42
Closed
TerminalGravity wants to merge 5 commits intomainfrom
Closed
test: add 20 tests for preflight_check triage integration#42TerminalGravity wants to merge 5 commits intomainfrom
TerminalGravity wants to merge 5 commits intomainfrom
Conversation
… and contracts The README references .preflight/ config extensively but there were no concrete example files to copy. This adds a ready-to-use examples/.preflight/ directory with annotated config.yml, triage.yml, and contracts/api.yml, plus a README explaining how to use them.
Created examples/USAGE_EXAMPLES.md with 8 real-world scenarios showing what each tool looks like in practice: preflight_check catching vague prompts, scope_work creating execution plans, enrich_agent_task for sub-agents, sharpen_followup resolving ambiguity, session health checks, semantic history search, weekly scorecards, and prompt grading. Added link to usage examples in README nav bar.
- Fixed extractText to filter by b.type === 'text' (was counting tool_use blocks as text tokens, inflating estimates) - Exported analyzeSessionFile and SessionAnalysis for testability - Added 7 tests covering: token counting, correction detection, tool call counting, preflight tool tracking, content block filtering, tool_result handling, malformed input, and epoch timestamps - Test count: 43 → 50
Covers trivial/clear/ambiguous/cross-service/multi-step classification, skip/always_check keywords, strictness modes, edge cases (empty prompt, bullet lists, pronoun detection, vague verbs).
Collaborator
Author
|
Superseded by newer PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds comprehensive test coverage for the
preflight_checktool's triage integration — the main entry point had zero tests.Coverage:
All 70 tests pass (20 new + 50 existing).