Added clang as a valid option for projects generated with vs2019#1462
Merged
samsinsane merged 1 commit intopremake:masterfrom Jun 11, 2020
nickclark2016:master
Merged
Added clang as a valid option for projects generated with vs2019#1462samsinsane merged 1 commit intopremake:masterfrom nickclark2016:master
samsinsane merged 1 commit intopremake:masterfrom
nickclark2016:master
Conversation
samsinsane
requested changes
Jun 8, 2020
Member
samsinsane
left a comment
samsinsane
left a comment
There was a problem hiding this comment.
Just a small change, can you also rebase and squish your commits. Other than this, everything looks great thanks for making this change!
samsinsane
approved these changes
Jun 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR unifies the functionality of the
clangtoolset across gmake/gmake2 and VS2019+ actions. Formerly,clangwould not resolve to a valid toolset, so it would be set to the default toolset of the Visual Studio version (e.g.v142for VS2019). This allows the vs2010 project generator to resolve "clang" to the correct platform toolset in the project file.How does this PR change Premake's behavior?
This break any code that was relying on the value
clangto resolve tov142in VS2019. Instead,clangnow resolves toClangCLin thePlatformToolsetof the project file. Issue #1461 describes the full affects of the changes. This should only affect projects generated with thevs2019action.