Merged
Conversation
added 2 commits
October 23, 2020 09:58
* Merge libdirs and syslibdirs to LIBRARY_SEARCH_PATHS setting * Add test
* Use the new Xcode 9+ setting SYSTEM_HEADER_SEARCH_PATHS settings instead of HEADER_SEARCH_PATHS * Update test
starkos
approved these changes
Oct 28, 2020
Member
starkos
left a comment
starkos
left a comment
There was a problem hiding this comment.
This looks okay to me, but I'm not doing any Xcode work these days.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
SYSTEM_HEADER_SEARCH_PATHS)How does this PR change Premake's behavior?
Xcode 8 and earlier will not recognize
SYSTEM_HEADER_SEARCH_PATHSsettingAnything else we should know?
As discussed in #1456, a Xcode target version may be added later to support the previous behaviour
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)