AllowUnsafeBlocks will now be a project level property in new format#1565
Merged
samsinsane merged 1 commit intopremake:masterfrom Dec 8, 2020
Merged
AllowUnsafeBlocks will now be a project level property in new format#1565samsinsane merged 1 commit intopremake:masterfrom
samsinsane merged 1 commit intopremake:masterfrom
Conversation
ClxS
changed the title
samsinsane
approved these changes
Dec 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moves the location of AllowUnsafeBlocks into the top-level project settings on net format C# projects.
Closes #1549
How does this PR change Premake's behavior?
Should not affect existing .NET Framework projects. Will affect .NET Standard, .NET Core, and .NET projects by fixing conditionally block placed AllowUsingBlocks, which were being ignored by the compiler.
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!