os.outputof: add a second argument to select which stream to output#1589
Merged
samsinsane merged 3 commits intopremake:masterfrom Mar 10, 2021
Merged
Conversation
local o, e = os.outputof(cmd, streams)
Where streams could be one of
- "output" Only return standard output stream content
- "error" Only return standard error stream content
- "both" (default) Return both streams content
samsinsane
requested changes
Feb 17, 2021
samsinsane
approved these changes
Mar 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How does this PR change Premake's behavior?
Allow to filter standard output or error stream content from os.outputof() return value.
Ignoring error output is important when the invoked command may return an exit code 0 (success) but output some content on the error stream which will pollute the text result.
Are there any breaking changes? Will any existing behavior change?
The default behavior follow the previous one (report both streams)
closes #XXXXin comment to auto-close issue when PR is merged)