Skip to content

Remove "*ng" action deprecation and auto-fix #1625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
starkos merged 1 commit into from
May 11, 2021
Merged

Remove "*ng" action deprecation and auto-fix #1625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/_premake_main.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,11 +172,6 @@
---

function m.prepareAction()
-- The "next-gen" actions have now replaced their deprecated counterparts.
-- Provide a warning for a little while before I remove them entirely.
if _ACTION and _ACTION:endswith("ng") then
p.warnOnce(_ACTION, "'%s' has been deprecated; use '%s' instead", _ACTION, _ACTION:sub(1, -3))
end
p.action.set(_ACTION)

-- Allow the action to initialize stuff.
Expand Down
4 changes: 0 additions & 4 deletions src/base/action.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,10 +155,6 @@
---

function action.get(name)
-- "Next-gen" actions are deprecated
if name and name:endswith("ng") then
name = name:sub(1, -3)
end
return action._list[name]
end

Expand Down