Skip to content

Adding documentation for module options#1745

Merged
KyrietS merged 1 commit intopremake:masterfrom
hannes-harnisch:master
Nov 5, 2021
Merged

Adding documentation for module options#1745
KyrietS merged 1 commit intopremake:masterfrom
hannes-harnisch:master

Conversation

@hannes-harnisch
Copy link
Contributor

What does this PR do?

The website currently does not fully document the module-related options for the compileas setting. I implemented these settings in #1570. I added basic descriptions about what the individual settings do. The terms used reflect those used in the C++20 standard. I think more detailed descriptions aren't necessary, as they would probably easily branch out into a lengthy description of C++20 modules, which shouldn't be the purpose of this page.

How does this PR change Premake's behavior?

In no way. It's purely documentation.

Anything else we should know?

No.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

@hannes-harnisch
Copy link
Contributor Author

I'm unsure on what makes the website check fail.

@KyrietS
Copy link
Member

KyrietS commented Nov 5, 2021

I'm looking into this.

UPDATE
I couldn't reproduce this error locally. Re-run passed.

@KyrietS KyrietS merged commit b1d477f into premake:master Nov 5, 2021
@KyrietS
Copy link
Member

KyrietS commented Nov 5, 2021

Thanks for your help in documenting those values! 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants