Hopefully fixed mistakes in quoting#1936
Closed
AaronNGray wants to merge 1 commit intopremake:masterfrom
AaronNGray:patch-1
Closed
Hopefully fixed mistakes in quoting#1936AaronNGray wants to merge 1 commit intopremake:masterfrom AaronNGray:patch-1
AaronNGray wants to merge 1 commit intopremake:masterfrom
AaronNGray:patch-1
Conversation
Author
|
Documentation fixes just need checking. |
| buildmessage 'Compiling %(Filename) with MyCustomCC' | ||
| buildcommands 'MyCustomCC.exe -c "%(FullPath)" -o "%(IntDir)/%(Filename).obj"' | ||
| buildoutputs '%(IntDir)/%(Filename).obj"' | ||
| buildoutputs '%(IntDir)/%(Filename).obj' |
Member
There was a problem hiding this comment.
Should we insert a quote before intdir rather than removing the trailing?
thomashope
reviewed
Sep 9, 2022
| propertydefinition { | ||
| name = "StripDebugInfo", | ||
| ind = "boole | ||
| ind = "boolean", |
Contributor
There was a problem hiding this comment.
I believe this should also be kind rather than ind?
Member
There was a problem hiding this comment.
I think so as well. Not 100% sure what happened to this file, but it appears that it got messed up.
Author
|
@nickclark2016 Yes probably better to correct it at your end as one commit |
Member
Wait, did I just get roped into fixing this? |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Hopefully fix some mistakes in quoting and a cropped line ending.
Thanks for the contribution! Please provide a concise description of the problem this request solves.
How does this PR change Premake's behavior?
Its just the documentation.
Anything else we should know?
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!