Skip to content

Comments

Use admonitions in documentation for things marked as deprecated#1959

Merged
samsinsane merged 1 commit intopremake:masterfrom
thomashope:master
Sep 19, 2022
Merged

Use admonitions in documentation for things marked as deprecated#1959
samsinsane merged 1 commit intopremake:masterfrom
thomashope:master

Conversation

@thomashope
Copy link
Contributor

What does this PR do?

Wraps deprecation notices in caution admonitions and moves them to the top for clarity.

When individual items in a table have been deprecated, those items are extracted to a table below with a caution admonition above. IMHO this makes it less likely someone will neglect to fully read the documentation and end up using a deprecated parameter.

How does this PR change Premake's behavior?

No, just documentation.

Anything else we should know?

Follow on from suggestions made during #1954

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

@samsinsane samsinsane merged commit 0078c17 into premake:master Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants