Skip to content

Comments

Android projects use IncludePath instead of ExternalIncludePath#1976

Merged
nickclark2016 merged 1 commit intopremake:masterfrom
LORgames:ssurtees/externalincludedirs
Oct 7, 2022
Merged

Android projects use IncludePath instead of ExternalIncludePath#1976
nickclark2016 merged 1 commit intopremake:masterfrom
LORgames:ssurtees/externalincludedirs

Conversation

@samsinsane
Copy link
Member

What does this PR do?

Changes Android projects so they use IncludePath instead of ExternalIncludePath as this appears to be ignored resulting in projects failing to build that worked in VS2019.

How does this PR change Premake's behavior?

N/A

Anything else we should know?

N/A

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

@nickclark2016 nickclark2016 merged commit 46e12d3 into premake:master Oct 7, 2022
@samsinsane samsinsane deleted the ssurtees/externalincludedirs branch October 7, 2022 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants