Add AntTarget to vsandroid project file#1992
Merged
samsinsane merged 1 commit intopremake:masterfrom Apr 15, 2023
Merged
Conversation
nickclark2016
requested changes
Oct 31, 2022
Member
nickclark2016
left a comment
nickclark2016
left a comment
There was a problem hiding this comment.
Can you add a corresponding unit test?
Contributor
Author
|
Unfortunately I don't know how, if there is a unit test for the "AndroidAppLibName" element which is already in there I could follow suit but I cannot find it...? |
samsinsane
approved these changes
Apr 15, 2023
Member
samsinsane
left a comment
samsinsane
left a comment
There was a problem hiding this comment.
I'm going to merge this since we don't have unit tests for a lot of the Android module currently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds AntTarget to .androidproj files
How does this PR change Premake's behavior?
All the android builds used to be built targeting the debug mode, which adds android:debuggable=true, generates a different BuildConfig.java (Debug=true), etc.
This is unacceptable for release builds.
Anything else we should know?
I'm not sure when did VS add this option but I don't think adding this on older VS versions would hurt anything.
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)