Add validation for toolset.#1997
Merged
samsinsane merged 1 commit intopremake:masterfrom Apr 16, 2023
Merged
Conversation
Jarod42
commented
Nov 11, 2022
|
|
||
| function m.actionSupportsToolset(prj) | ||
| if not p.action.supportsToolset(prj.language, prj.toolset) then | ||
| p.warn("Unsupported toolset '%s' used for language '%s' for project '%s'", prj.toolset, prj.language, prj.name) |
Contributor
Author
There was a problem hiding this comment.
Most other validations use warn and not error...
So I stay coherent with above checks. (but I think all should be error).
src/base/action.lua
Outdated
| --- | ||
|
|
||
| function action.supportsToolset(language, toolset) | ||
| local function buildLanguageKeysMap() |
Contributor
Author
There was a problem hiding this comment.
Not sure how it should be done with extern registered languages. Apply to valid_tools entry or registered action anyway...
samsinsane
approved these changes
Apr 15, 2023
Member
samsinsane
left a comment
samsinsane
left a comment
There was a problem hiding this comment.
Overall, this looks good. I'm a bit concerned that it might be emitting the warning on valid uses since we probably haven't been updating the valid_tools along the way, but we can just make sure they're all fixed up before the next release.
Jarod42
force-pushed
the
toolset_validation
branch
from
0b0541b to
716a57d
Compare
Contributor
Author
|
Tests actually fail as master fails. |
Jarod42
force-pushed
the
toolset_validation
branch
from
716a57d to
504f6fc
Compare
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add validation for toolset.
So
valid_toolsis now useful.How does this PR change Premake's behavior?
Add a message for invalid configuration for toolset
Anything else we should know?
No.
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!