Merged
Conversation
| table.insert(flags, "/SUBSYSTEM:CONSOLE") | ||
| elseif cfg.kind ~= "WindowedApp" then -- already set by above map | ||
| table.insert(flags, "/SUBSYSTEM:NATIVE") -- fallback | ||
| end |
Member
There was a problem hiding this comment.
Just to confirm, cfg.kind == "WindowedApp" is set by the above mapFlags call?
Contributor
Author
There was a problem hiding this comment.
Yes, there is just above (line 290)
kind = {
SharedLib = "/DLL",
WindowedApp = "/SUBSYSTEM:WINDOWS"
},
samsinsane
approved these changes
Apr 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Handle entrypoint for msc (for no vs* action).
How does this PR change Premake's behavior?
Just change msc toolset for
entrypoint "somefunc"Anything else we should know?
Tested locally (not on https://github.com/Jarod42/premake-sample-projects as usual #2003 (
--cc=msc) would be required there to test it properly.Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)