externalwarnings, externalanglebrackets, externalincludedirs was already available in vs2019#2006
Merged
samsinsane merged 1 commit intopremake:masterfrom Dec 11, 2022
Merged
Conversation
…s already available in vs2019
Jarod42
force-pushed
the
externalwarnings_vs2019
branch
from
d82767f to
998cbc7
Compare
Contributor
Author
Again random network error unrelated to actual changes. |
Member
I've rerun failed jobs but for future reference, you can try making a phantom commit by: |
samsinsane
approved these changes
Dec 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
externalwarnings,externalanglebrackets,externalincludedirsis now handled for vs2019How does this PR change Premake's behavior?
Change action vs2019 (and msc-v142) to support too the above flags.
Anything else we should know?
No.
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!