Skip to content

Comments

Add term.clearToEndOfLine and term.moveLeft API additions.#2253

Merged
samsinsane merged 2 commits intopremake:masterfrom
tritao:term-apis
Sep 24, 2024
Merged

Add term.clearToEndOfLine and term.moveLeft API additions.#2253
samsinsane merged 2 commits intopremake:masterfrom
tritao:term-apis

Conversation

@tritao
Copy link
Contributor

@tritao tritao commented Sep 19, 2024

What does this PR do?

Adds term.clearToEndOfLine and term.moveLeft APIs to term.

Anything else we should know?

These depend on ANSI escape codes, which from what I've read Windows now supports.

Haven't tested it on Windows yet and I think support for it needs to be explicitly enabled: https://superuser.com/a/1300251

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

@@ -491,7 +491,8 @@ module.exports = {
'term.getTextColor',
'term.popColor',
Copy link
Contributor

@Jarod42 Jarod42 Sep 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'term.moveLeft' is missing here.

@tritao tritao marked this pull request as ready for review September 21, 2024 10:31
@samsinsane samsinsane merged commit b92767a into premake:master Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants