Adds desktop system tag to desktop systems.#2254
Conversation
|
I left |
Jarod42
left a comment
There was a problem hiding this comment.
Sad that the whole documentation is obsolete/missing for that part:
os.istargetis missingos.isis deprecated and redirect toos.target...
Ok, I can add those missing docs and include the concept of tags too. |
|
Updated the PR with some docs. |
c86265b to
f75f657
Compare
f75f657 to
19538dc
Compare
|
Updated PR with review suggestions. Also found meanwhile https://github.com/Blizzard/premake-blizzard/blob/master/blizzard.lua#L25, so it shows some prior art as this being useful to someone else at least. |
I guess it depends on what "mobile" means? Do we factor in Windows Phone despite it being unsupported by Microsoft for years already? I don't think we should. Does tagging with both create problems with usage? Using both Personally, I think |
19538dc to
bd20fd0
Compare
Ok, this sounds reasonable to me, I have updated the PR with that suggestion. |
samsinsane
left a comment
There was a problem hiding this comment.
Minor issues, but otherwise looks good.
bd20fd0 to
8e7a427
Compare
|
Thanks for the review, all should be fixed now, and updated the docs with a table reference for the tags. |
This can be useful to use to filter desktop systems, such as
`os.istarget("desktop")`.
8e7a427 to
5bd3969
Compare
This can be useful to use to filter desktop systems, such as
os.istarget("desktop").