Skip to content

Comments

Added ci job to simplify required checks in PRs#2279

Merged
samsinsane merged 1 commit intopremake:masterfrom
LORgames:ssurtees/ciJob
Oct 3, 2024
Merged

Added ci job to simplify required checks in PRs#2279
samsinsane merged 1 commit intopremake:masterfrom
LORgames:ssurtees/ciJob

Conversation

@samsinsane
Copy link
Member

What does this PR do?

Creates a single job that we can require for approval of PRs. GitHub doesn't allow us to require the whole CI workflow, or a specific job such as linux, we must require each combination from the matrix setting; linux (debug, x64) and linux (release, x64). A new axis in the matrix setting replaces all combinations with new combinations, this means that linux (debug, x64) becomes linux (debug, x64, ...) but GitHub will still be requiring linux (debug, x64) which won't exist - #2275 is an example of this happening.

This new job allows us to select a single job that will automatically depend on all versions of the jobs we specify using the needs setting. The purpose of this job is to group all of our required jobs statuses into a single job status that we can require from GitHub.

How does this PR change Premake's behavior?

N/A

Anything else we should know?

N/A

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

@samsinsane samsinsane merged commit e5bde4b into premake:master Oct 3, 2024
@samsinsane samsinsane deleted the ssurtees/ciJob branch October 3, 2024 03:34
@Jarod42 Jarod42 mentioned this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants