Added ci job to simplify required checks in PRs#2279
Merged
samsinsane merged 1 commit intopremake:masterfrom Oct 3, 2024
Merged
Added ci job to simplify required checks in PRs#2279samsinsane merged 1 commit intopremake:masterfrom
samsinsane merged 1 commit intopremake:masterfrom
Conversation
Jarod42
approved these changes
Oct 2, 2024
tritao
approved these changes
Oct 2, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Creates a single job that we can require for approval of PRs. GitHub doesn't allow us to require the whole CI workflow, or a specific job such as
linux, we must require each combination from thematrixsetting;linux (debug, x64)andlinux (release, x64). A new axis in the matrix setting replaces all combinations with new combinations, this means thatlinux (debug, x64)becomeslinux (debug, x64, ...)but GitHub will still be requiringlinux (debug, x64)which won't exist - #2275 is an example of this happening.This new job allows us to select a single job that will automatically depend on all versions of the jobs we specify using the
needssetting. The purpose of this job is to group all of our required jobs statuses into a single job status that we can require from GitHub.How does this PR change Premake's behavior?
N/A
Anything else we should know?
N/A
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!