Remove generated "website/node_modules"'s files from project#2299
Merged
KyrietS merged 2 commits intopremake:masterfrom Oct 14, 2024
Merged
Remove generated "website/node_modules"'s files from project#2299KyrietS merged 2 commits intopremake:masterfrom
KyrietS merged 2 commits intopremake:masterfrom
Conversation
KyrietS
approved these changes
Oct 14, 2024
KyrietS
requested changes
Oct 14, 2024
Jarod42
force-pushed
the
remove_website_node_modules
branch
from
f384f0e to
7c9ed73
Compare
Contributor
Unfortunately that doesn't really fix the slowdown as Premake still enumerates everything. I can see at least two potential solutions:
|
Jarod42
force-pushed
the
remove_website_node_modules
branch
from
7c9ed73 to
9bc941b
Compare
Contributor
Author
It was my doubt.
Done |
tritao
reviewed
Oct 14, 2024
Contributor
|
That works. 👍 |
Co-authored-by: João Matos <joao@tritao.eu>
tritao
approved these changes
Oct 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
According to #2294 comments, there is a slowdown
so removing the extra generated files under website/node_modules
How does this PR change Premake's behavior?
No behavior change.
Anything else we should know?
@tritao: is it ok like that?
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!