Skip to content

Comments

Handle fatalwarnings for specific warnings (not 'All') for visual studio with clang#2531

Merged
samsinsane merged 1 commit intopremake:masterfrom
Jarod42:fatalwarnings_msvc_clang
Nov 6, 2025
Merged

Handle fatalwarnings for specific warnings (not 'All') for visual studio with clang#2531
samsinsane merged 1 commit intopremake:masterfrom
Jarod42:fatalwarnings_msvc_clang

Conversation

@Jarod42
Copy link
Contributor

@Jarod42 Jarod42 commented Nov 6, 2025

What does this PR do?

Handle fatalwarnings for specific warnings (not 'All') for visual studio with clang

How does this PR change Premake's behavior?

change vs action to handle fatalwarnings with clang toolset

Anything else we should know?

Tested with https://github.com/Jarod42/premake-sample-projects/actions/runs/19131565364
on https://github.com/Jarod42/premake-sample-projects/tree/master/projects/fatalwarnings

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • [ x Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

@Jarod42 Jarod42 force-pushed the fatalwarnings_msvc_clang branch from 1e05a21 to 993ad28 Compare November 6, 2025 10:45
@Jarod42 Jarod42 marked this pull request as draft November 6, 2025 11:00
@Jarod42 Jarod42 force-pushed the fatalwarnings_msvc_clang branch from 993ad28 to 3ceeec5 Compare November 6, 2025 11:09
@Jarod42 Jarod42 marked this pull request as ready for review November 6, 2025 11:30
@samsinsane samsinsane merged commit 3712dbd into premake:master Nov 6, 2025
49 checks passed
@Jarod42 Jarod42 deleted the fatalwarnings_msvc_clang branch November 6, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants