Merged
Conversation
Jarod42
reviewed
Dec 22, 2025
Jarod42
reviewed
Dec 22, 2025
|
|
||
| function config.isCopyLocal(cfg, linkname, default) | ||
| if cfg.flags.NoCopyLocal then | ||
| if cfg.allowcopylocal == p.OFF then |
Contributor
There was a problem hiding this comment.
It seems to assume that 'Default' is 'On'
Member
Author
There was a problem hiding this comment.
"Default" would be handled by the underlying exporter's behavior
Jarod42
reviewed
Dec 22, 2025
src/_premake_init.lua
Outdated
| scope = "config", | ||
| kind = "string", | ||
| allowed = { | ||
| "Default", |
Contributor
There was a problem hiding this comment.
Wonder at which point we want explicit 'Default' value.
premake can have default = 'On'.
nickclark2016
force-pushed
the
deprecate-no-copy-local
branch
2 times, most recently
from
8aec425 to
48576e3
Compare
samsinsane
reviewed
Dec 22, 2025
nickclark2016
force-pushed
the
deprecate-no-copy-local
branch
from
48576e3 to
26d6418
Compare
Jarod42
approved these changes
Dec 22, 2025
samsinsane
approved these changes
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Deprecates the
NoCopyLocalflag in favor of a dedicated API,allowcopylocal.How does this PR change Premake's behavior?
No breaking changes, just deprecation.
Anything else we should know?
Preparation for 5.0
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!