Deprecate NoRuntimeChecks, add dedicated API#2583
Conversation
e11551d to
4206b4e
Compare
|
Not quite sure I understand this comment: Off (performs no checks, maps to "Default" in IDE, maps to NoRuntimeChecks flag behavior) Particularly the "maps to Default" and "uses exporter defaults" bits, the comments in the docs do sound sensible but contradict the comment, am I reading these wrong? |
4206b4e to
9075ef5
Compare
Yeah, I'm not sure what the best way to word this is. Basically, if we want to be "Default" in how Premake defines the default (aka don't emit a value and just let the exporter determine), we need to leave it empty. However, there is an explicit "Default" value in VS that actually maps better to "Off" (Microsoft sucks at naming). Would gladly take any wording suggestions here. |
9075ef5 to
0176b55
Compare
What does this PR do?
Deprecates the NoRuntimeChecks flag. Adds a new API for `runtimechecks with the following fields:
How does this PR change Premake's behavior?
No breaking changes
Anything else we should know?
Prep for 5.0
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!