Skip to content

chore(deps): Upgrade dep.okhttp.version to 5.3.2#27354

Draft
nishithakbhaskaran wants to merge 1 commit intoprestodb:masterfrom
nishithakbhaskaran:okio-upgrade
Draft

chore(deps): Upgrade dep.okhttp.version to 5.3.2#27354
nishithakbhaskaran wants to merge 1 commit intoprestodb:masterfrom
nishithakbhaskaran:okio-upgrade

Conversation

@nishithakbhaskaran
Copy link
Contributor

@nishithakbhaskaran nishithakbhaskaran commented Mar 17, 2026

Description

Upgrade dep.okhttp.version to 5.3.2

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
  • If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* ... 
* ... 

Hive Connector Changes
* ... 
* ... 

If release note is NOT required, use:

== NO RELEASE NOTE ==

Summary by Sourcery

Upgrade OkHttp and Okio dependencies to the latest 5.3.2/3.16.4 stack and adjust usage across modules and tests to the new APIs.

Enhancements:

  • Switch all modules from okhttp to okhttp-jvm and from mockwebserver to mockwebserver3, aligning with the new OkHttp 5 artifact layout.
  • Update OkHttp-based tests to use the new MockResponse.Builder API, URL accessors, and HTTPS configuration required by OkHttp 5.
  • Add okhttp-jvm to dependency management and update Maven dependency plugin ignore lists for new okhttp and Kotlin stdlib dependencies.

Build:

  • Bump global OkHttp version to 5.3.2 and Okio JVM version to 3.16.4 in parent and spark-base POMs.
  • Introduce explicit okhttp-jvm dependency and mockwebserver3 test dependency in relevant modules and dependencyManagement sections.

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Mar 17, 2026
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 17, 2026

Reviewer's Guide

Upgrades OkHttp (and Okio) to the 5.3.2 line across modules and adapts tests, dependency declarations, and mock server usage to the new APIs and artifacts, including okhttp-jvm and mockwebserver3, plus minor Kotlin interop changes for request tagging and Maven plugin ignore lists.

File-Level Changes

Change Details Files
Bump OkHttp and Okio versions and switch core artifacts to okhttp-jvm across the project.
  • Update root dep.okhttp.version to 5.3.2 and align dep.okio-jvm.version to 3.16.4
  • Add okhttp-jvm to dependencyManagement and various module POMs instead of okhttp
  • Ensure modules that directly use OkHttp declare explicit okhttp-jvm version when not inherited
pom.xml
presto-spark-base/pom.xml
presto-cli/pom.xml
presto-client/pom.xml
presto-jdbc/pom.xml
presto-prometheus/pom.xml
presto-benchmark-driver/pom.xml
presto-plan-checker-router-plugin/pom.xml
presto-tests/pom.xml
Migrate from mockwebserver to mockwebserver3 and adapt tests to the new API surface.
  • Replace mockwebserver artifact with mockwebserver3 in all relevant module POMs
  • Update test code to use MockResponse.Builder(), body(), code(), and new accessors such as getUrl() / encodedPath()
  • Adjust HTTPS setup and other API calls (e.g., useHttps, request URL accessors) to new MockWebServer signatures
presto-main/pom.xml
presto-router/pom.xml
presto-cli/pom.xml
presto-client/pom.xml
presto-jdbc/pom.xml
presto-router/src/test/java/com/facebook/presto/router/TestPredictorManager.java
presto-cli/src/test/java/com/facebook/presto/cli/AbstractCliTest.java
presto-cli/src/test/java/com/facebook/presto/cli/TestTemporaryFunctions.java
presto-cli/src/test/java/com/facebook/presto/cli/TestQueryRunner.java
presto-cli/src/test/java/com/facebook/presto/cli/TestInsecureQueryRunner.java
presto-client/src/test/java/com/facebook/presto/client/auth/external/TestHttpTokenPoller.java
presto-jdbc/src/test/java/com/facebook/presto/jdbc/TestQueryExecutor.java
presto-jdbc/src/test/java/com/facebook/presto/jdbc/TestProgressMonitor.java
Update test HTTP client wrapper and request tagging to be compatible with OkHttp 5 APIs and Kotlin interop.
  • Implement new tag overloads (Class-based and KClass-based, with optional defaultValue) in the PrestoSpark test HTTP client request wrapper
  • Delegate tag resolution to the underlying OkHttp Request and use Kotlin JvmClassMapping to bridge KClass to Java Class
presto-spark-base/src/test/java/com/facebook/presto/spark/execution/http/TestPrestoSparkHttpClient.java
Adjust Maven dependency-plugin configuration to account for new transitive dependencies and okhttp-jvm packaging.
  • Add okhttp-jvm and kotlin-stdlib entries to ignoredUsedUndeclaredDependencies and ignoredNonTestScopedDependencies where needed
  • Update existing ignore lists from okhttp to okhttp-jvm so dependency analysis stays clean with the new artifacts
presto-router/pom.xml
presto-spark-base/pom.xml
presto-main/pom.xml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@nishithakbhaskaran nishithakbhaskaran changed the title [DNR- WIP]Upgrade dep.okhttp.version to 5.3.2 chore(deps): Upgrade dep.okhttp.version to 5.3.2 Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:IBM PR from IBM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants