Skip to content

Conversation

@Shinigami92
Copy link
Member

closes #365

depends on prettier release of prettier/prettier#12584

@Shinigami92 Shinigami92 added type: bug Functionality that does not work as intended/expected framework: Vue Related to the framework Vue labels Apr 16, 2022
@Shinigami92 Shinigami92 self-assigned this Apr 16, 2022
@github-actions
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 94.69% (🎯 90%)
⬆️ +0.03%
2697 / 2848
🟢 Statements 94.69% (🎯 90%)
⬆️ +0.03%
2697 / 2848
🟢 Functions 96.36% (🎯 90%)
⬆️ +0.07%
106 / 110
🟢 Branches 93.03% (🎯 90%)
⬆️ +0.07%
641 / 689
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/printer.ts 94.26%
⬆️ +0.05%
94.25%
⬆️ +0.09%
100%
🟰 ±0%
94.26%
⬆️ +0.05%
337-338, 374-375, 524-526, 538-547, 552-565, 613-649, 665-666, 704-705, 790-794, 1143-1144, 1237-1238, 1265, 1274-1275, 1566-1567, 1613-1614, 1939-1945, 1983-1988
Unchanged Files
src/doctype-shortcut-registry.ts 100% 100% 100% 100%
src/index.ts 93.18% 100% 71.42% 93.18% 79-81, 84-86
src/logger.ts 77.46% 90.9% 81.81% 77.46% 37-46, 93-94, 153-157
src/options/common.ts 100% 100% 100% 100%
src/options/constants.ts 100% 100% 100% 100%
src/options/converge.ts 100% 60% 100% 100%
src/options/index.ts 100% 100% 100% 100%
src/options/pug-attribute-separator.ts 89.74% 75% 100% 89.74% 52-55
src/options/pug-class-location.ts 100% 100% 100% 100%
src/options/pug-class-notation.ts 100% 100% 100% 100%
src/options/pug-closing-bracket-indent-depth.ts 100% 100% 100% 100%
src/options/pug-comment-preserve-spaces.ts 100% 100% 100% 100%
src/options/pug-explicit-div.ts 100% 100% 100% 100%
src/options/pug-framework.ts 100% 100% 100% 100%
src/options/pug-id-notation.ts 100% 100% 100% 100%
src/options/pug-preserve-attribute-brackets.ts 100% 100% 100% 100%
src/options/pug-preserve-whitespace.ts 100% 100% 100% 100%
src/options/pug-single-file-component-indentation.ts 100% 100% 100% 100%
src/options/pug-wrap-attributes.ts 100% 100% 100% 100%
src/options/types.ts 100% 100% 100% 100%
src/options/attribute-sorting/index.ts 100% 100% 100% 100%
src/options/attribute-sorting/utils.ts 95.69% 94.44% 100% 95.69% 82-83, 94-95
src/options/empty-attributes/index.ts 100% 100% 100% 100%
src/options/empty-attributes/types.ts 100% 100% 100% 100%
src/options/empty-attributes/utils.ts 100% 100% 100% 100%
src/utils/angular.ts 100% 100% 100% 100%
src/utils/common.ts 89.67% 86.11% 100% 89.67% 19-20, 27-28, 56-57, 258-259, 262-263, 269-272, 331-332
src/utils/script-mime-types.ts 87.5% 83.33% 100% 87.5% 42-43, 49-50
src/utils/svelte.ts 100% 100% 100% 100%
src/utils/vue.ts 100% 100% 100% 100%
Generated in workflow #600 for commit 7262ab9 by the Vitest Coverage Report Action

@Shinigami92 Shinigami92 marked this pull request as ready for review April 28, 2025 18:37
@Shinigami92 Shinigami92 merged commit 136b5b5 into main Apr 28, 2025
10 checks passed
@Shinigami92 Shinigami92 deleted the issue-365 branch April 28, 2025 18:37
@fisker
Copy link
Member

fisker commented Apr 28, 2025

Is it hard to check <script lang="ts">? Better align logic with vue parser.

@fisker
Copy link
Member

fisker commented Apr 28, 2025

Oh, you don't have the Vue AST at all.

@fisker
Copy link
Member

fisker commented Apr 28, 2025

prettier/prettier#17415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework: Vue Related to the framework Vue type: bug Functionality that does not work as intended/expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Cannot format expressions in Vue using TS types

3 participants