Allow external context injection to the Editor component#614
Open
noreplydev wants to merge 1 commit intoprevwong:mainfrom
Open
Allow external context injection to the Editor component#614noreplydev wants to merge 1 commit intoprevwong:mainfrom
noreplydev wants to merge 1 commit intoprevwong:mainfrom
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
noreplydev
changed the title
Contributor
Author
|
For anyone who needs this feature, I have created a fork in protofy-xyz/protocraft with this feature enabled and published in npm |
|
I also need this feature |
|
I need it too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now the @craftjs/core Editor component accepts an external context injection for advanced use cases where external management of the state is necessary.
Previously, you needed to be inside the context provider to have access to the store. Now, since you can pass it as prop, you can initialise the context outside and have access to it. However, the component works as usual if you do not pass the context prop.