fix(autocomplete): not opening on second click#16155
Merged
cetincakiroglu merged 2 commits intoprimefaces:masterfrom Aug 8, 2024
Merged
fix(autocomplete): not opening on second click#16155cetincakiroglu merged 2 commits intoprimefaces:masterfrom
cetincakiroglu merged 2 commits intoprimefaces:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Contributor
Author
|
Please let me know if you require further details! |
This was referenced Aug 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15281
This PR fixes the mentioned issue & additionally a bug in the overlay which would close the panel & never open it again (when opening & closing before the animation finishes) as the internal state of the overlay was half opened / half closed.
Details:
modalVisiblewasfalsewhilevisiblewas true. This basically "deadlocks" the overlay.Also fixes the minlength behavior for when "0" is used as a value.