fix: #12595 - Two onSort emits were triggered, when both sortField and sortOrder changed at once#18971
Open
EstelonAgarwaen wants to merge 1 commit intoprimefaces:masterfrom
Conversation
EstelonAgarwaen
changed the title
EstelonAgarwaen
changed the title
EstelonAgarwaen
force-pushed
the
only-emit-single-sort-event-when-using-inputs-for-sort-field-and-order
branch
from
5a1ff15 to
506567d
Compare
EstelonAgarwaen
changed the title
EstelonAgarwaen
force-pushed
the
only-emit-single-sort-event-when-using-inputs-for-sort-field-and-order
branch
from
506567d to
34e6653
Compare
Maran23
suggested changes
Oct 29, 2025
Contributor
Maran23
left a comment
Maran23
left a comment
There was a problem hiding this comment.
Fix makes sense. Have some minor comments.
Nice to see some more tests for the sorting!
I can confirm that one test fails before and passes after. The other tests pass before and after, as expected.
EstelonAgarwaen
force-pushed
the
only-emit-single-sort-event-when-using-inputs-for-sort-field-and-order
branch
from
2160b40 to
8e89a6f
Compare
EstelonAgarwaen
changed the title
EstelonAgarwaen
force-pushed
the
only-emit-single-sort-event-when-using-inputs-for-sort-field-and-order
branch
from
8e89a6f to
9eaea0b
Compare
EstelonAgarwaen
force-pushed
the
only-emit-single-sort-event-when-using-inputs-for-sort-field-and-order
branch
from
9eaea0b to
95bc1eb
Compare
…rtField and sortOrder changed at once
EstelonAgarwaen
force-pushed
the
only-emit-single-sort-event-when-using-inputs-for-sort-field-and-order
branch
from
95bc1eb to
b3f44b5
Compare
Maran23
approved these changes
Mar 12, 2026
Contributor
Maran23
left a comment
Maran23
left a comment
There was a problem hiding this comment.
Still good. Hope there will be an official review at one point. Thanks for changing it to the new testing approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #12595
When using
p-tablewithlazy=trueand setting thesortOrderandsortField-Inputs, theonSort-Emitter emitted two events.This PR fixes that issue, so that no matter which constellation of changes these inputs receive, there will be one emit on the
onSort-emitter.