Sidebar a11y fixes #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves sidebar accessibility by moving the sidebar before the main content and wrapping it in an aside element with a dynamic aria-label.
- Sidebar is now rendered within an aside element with a dynamic label based on the active header link or site title.
- The previous static sidebar pane has been removed to maintain a logical DOM order.
danielguillan
commented
Jul 1, 2025
| hidden={{narrow: true}} | ||
| divider="line" | ||
| > | ||
| <aside aria-label={`${activeHeaderLink ? activeHeaderLink.title : siteTitle} sidebar`}> |
Contributor
Author
There was a problem hiding this comment.
PageLayout.Pane is not polymorphic, so we need to nest the aside region here.
danielguillan
temporarily deployed
to
github-pages
GitHub Actions
Inactive
rezrah
reviewed
Jul 1, 2025
danielguillan
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/github/primer/issues/5381
This pull request moves the sidebar before the content in the DOM and introduces an
asideregion to enhance accessibility. The aria-label now dynamically displays the appropriate title based on the active header link or site title.