Add contribution graph tokens #1166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f0f57bd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Design Token Diff (CSS)
|
Contributor
Design Token Diff (StyleLint)The message is too long to be displayed here. For more details, please check the job summary. |
Contributor
Design Token Diff (Figma)The message is too long to be displayed here. For more details, please check the job summary. |
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
commented
Jan 25, 2025
Comment on lines
+86
to
+101
| 'org.primer.overrides': { | ||
| dark: { | ||
| $value: '{base.color.white}', | ||
| alpha: 0.05, | ||
| }, | ||
| 'dark-dimmed': { | ||
| $value: '{base.color.white}', | ||
| alpha: 0.05, | ||
| }, | ||
| 'dark-high-contrast': { | ||
| $value: '{base.color.white}', | ||
| alpha: 1, | ||
| }, | ||
| 'light-high-contrast': { | ||
| alpha: 1, | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
How does this look @lukasoppermann? Can I just override alpha like I've done for light high contrast?
Also, you may notice all of these border colors are the same (so why do we need individual tokens?) I plan to override them individually to achieve 3:1 contrast behind our border contrast feature flag. I'm not sure what the token structure will look like for that yet but I know I need custom values for each level 😄
…itives into contrib-graph-tokens
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
github-actions
bot
removed
the
update snapshots
lukasoppermann
approved these changes
Jan 27, 2025
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the contribution graph colors are custom (outside of Primer) and only support
lightanddark. I'd like to move them here so we can support all themes, including some upcoming contrast work.Part of https://github.com/github/accessibility-audits/issues/10272
I have attempted to match the existing custom colors as closely as possible. I'm renaming these to use a
contributionpattern name because "calendar" feels misleading. The number variants represent how many contributions.