Skip to content

Bug fixes #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
langermank merged 3 commits into from
Mar 26, 2025
Merged

Bug fixes #1200

langermank merged 3 commits into from
Mar 26, 2025

Conversation

@langermank
Copy link
Contributor

@langermank langermank commented Mar 26, 2025

Moving a few bug fixes from this PR into a separate PR to merge into main 😄

@changeset-bot
Copy link

changeset-bot bot commented Mar 26, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: e668395

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@langermank langermank added the update snapshots Update visual regression test snapshots label Mar 26, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2025 •
edited
Loading

Design Token Diff (CSS)

/css/functional/themes/dark-high-contrast.css

 
+++ /home/runner/work/primitives/primitives/dist/css/functional/themes/dark-high-contrast.css	2025-03-26 19:05:16.064425482 +0000
@@ -55,7 +55,7 @@
 --borderColor-sponsors-muted: #f87cbd;
 --borderColor-success-emphasis: #09b43a;
 --borderColor-success-muted: #0ac740;
-  --borderColor-translucent: #2f3742;
+  --borderColor-translucent: #9198a1;
 --borderColor-transparent: #00000000;
 --button-danger-borderColor-active: #ffb1af;
 --button-danger-borderColor-hover: #ffb1af;
@@ -165,7 +165,6 @@
 --control-checked-borderColor-active: #91cbff;
 --control-checked-borderColor-hover: #91cbff;
 --control-checked-borderColor-rest: #91cbff;
-  --control-danger-fgColor-hover: #ff9492;
 --control-fgColor-placeholder: #b7bdc8;
 --control-transparent-bgColor-active: #3d444d;
 --control-transparent-bgColor-hover: #2f3742;
@@ -633,6 +632,7 @@
 --control-borderColor-emphasis: var(--borderColor-emphasis);
 --control-checked-borderColor-disabled: var(--control-checked-bgColor-disabled);
 --control-checked-fgColor-rest: var(--fgColor-onEmphasis);
+  --control-danger-fgColor-hover: var(--fgColor-onEmphasis);
 --control-fgColor-rest: var(--fgColor-default);
 --controlKnob-bgColor-disabled: var(--control-bgColor-disabled);
 --controlKnob-bgColor-rest: var(--bgColor-inset);
@@ -744,7 +744,7 @@
   --borderColor-sponsors-muted: #f87cbd;
   --borderColor-success-emphasis: #09b43a;
   --borderColor-success-muted: #0ac740;
-    --borderColor-translucent: #2f3742;
+    --borderColor-translucent: #9198a1;
   --borderColor-transparent: #00000000;
   --button-danger-borderColor-active: #ffb1af;
   --button-danger-borderColor-hover: #ffb1af;
@@ -854,7 +854,6 @@
   --control-checked-borderColor-active: #91cbff;
   --control-checked-borderColor-hover: #91cbff;
   --control-checked-borderColor-rest: #91cbff;
-    --control-danger-fgColor-hover: #ff9492;
   --control-fgColor-placeholder: #b7bdc8;
   --control-transparent-bgColor-active: #3d444d;
   --control-transparent-bgColor-hover: #2f3742;
@@ -1322,6 +1321,7 @@
   --control-borderColor-emphasis: var(--borderColor-emphasis);
   --control-checked-borderColor-disabled: var(--control-checked-bgColor-disabled);
   --control-checked-fgColor-rest: var(--fgColor-onEmphasis);
+    --control-danger-fgColor-hover: var(--fgColor-onEmphasis);
   --control-fgColor-rest: var(--fgColor-default);
   --controlKnob-bgColor-disabled: var(--control-bgColor-disabled);
   --controlKnob-bgColor-rest: var(--bgColor-inset);

/css/functional/themes/light-high-contrast.css

 
+++ /home/runner/work/primitives/primitives/dist/css/functional/themes/light-high-contrast.css	2025-03-26 19:05:07.883336041 +0000
@@ -61,6 +61,7 @@
 --borderColor-translucent: #59636e;
 --borderColor-transparent: #ffffff00;
 --button-danger-bgColor-hover: #86061d;
+  --button-danger-borderColor-hover: #6e011a;
 --button-danger-shadow-selected: inset 0px 1px 0px 0px #43001133;
 --button-inactive-fgColor: #454c54;
 --button-invisible-bgColor-disabled: #ffffff00;
@@ -470,7 +471,7 @@
 --borderColor-upsell-emphasis: var(--borderColor-done-emphasis);
 --borderColor-upsell-muted: var(--borderColor-done-muted);
 --button-danger-bgColor-rest: var(--control-bgColor-rest);
-  --button-danger-borderColor-hover: var(--button-primary-borderColor-rest);
+  --button-danger-borderColor-active: var(--button-danger-borderColor-hover);
 --button-danger-fgColor-active: #ffffff;
 --button-danger-fgColor-disabled: #86061d80;
 --button-danger-fgColor-hover: #ffffff;
@@ -617,7 +618,6 @@
 --border-upsell-muted: 0.0625rem solid #a371f7;
 --borderColor-neutral-muted: var(--borderColor-muted);
 --button-danger-bgColor-disabled: var(--control-bgColor-disabled);
-  --button-danger-borderColor-active: var(--button-danger-borderColor-hover);
 --button-danger-borderColor-rest: var(--control-borderColor-rest);
 --button-default-bgColor-disabled: var(--control-bgColor-disabled);
 --button-default-borderColor-active: var(--control-borderColor-rest);
@@ -750,6 +750,7 @@
   --borderColor-translucent: #59636e;
   --borderColor-transparent: #ffffff00;
   --button-danger-bgColor-hover: #86061d;
+    --button-danger-borderColor-hover: #6e011a;
   --button-danger-shadow-selected: inset 0px 1px 0px 0px #43001133;
   --button-inactive-fgColor: #454c54;
   --button-invisible-bgColor-disabled: #ffffff00;
@@ -1159,7 +1160,7 @@
   --borderColor-upsell-emphasis: var(--borderColor-done-emphasis);
   --borderColor-upsell-muted: var(--borderColor-done-muted);
   --button-danger-bgColor-rest: var(--control-bgColor-rest);
-    --button-danger-borderColor-hover: var(--button-primary-borderColor-rest);
+    --button-danger-borderColor-active: var(--button-danger-borderColor-hover);
   --button-danger-fgColor-active: #ffffff;
   --button-danger-fgColor-disabled: #86061d80;
   --button-danger-fgColor-hover: #ffffff;
@@ -1306,7 +1307,6 @@
   --border-upsell-muted: 0.0625rem solid #a371f7;
   --borderColor-neutral-muted: var(--borderColor-muted);
   --button-danger-bgColor-disabled: var(--control-bgColor-disabled);
-    --button-danger-borderColor-active: var(--button-danger-borderColor-hover);
   --button-danger-borderColor-rest: var(--control-borderColor-rest);
   --button-default-bgColor-disabled: var(--control-bgColor-disabled);
   --button-default-borderColor-active: var(--control-borderColor-rest);

@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2025 •
edited
Loading

Design Token Diff (StyleLint)

/styleLint/functional/themes/dark-colorblind.json

 
+++ /home/runner/work/primitives/primitives/dist/styleLint/functional/themes/dark-colorblind.json	2025-03-26 19:05:14.405407367 +0000
@@ -3688,7 +3688,7 @@
         "$type": "color"
       },
       "dark-high-contrast": {
-          "$value": "#2f3742",
+          "$value": "#9198a1",
         "alpha": 1,
         "filePath": "src/tokens/functional/color/borderColor.json5",
         "isSource": true,
@@ -3717,7 +3717,7 @@
           "$type": "color"
         },
         "dark-high-contrast": {
-            "$value": "{base.color.neutral.6}",
+            "$value": "{base.color.neutral.9}",
           "alpha": 1,
           "filePath": "src/tokens/functional/color/borderColor.json5",
           "isSource": true,
@@ -4180,6 +4180,13 @@
         "filePath": "src/tokens/component/button.json5",
         "isSource": true,
         "$type": "color"
+        },
+        "light-high-contrast": {
+          "$value": "#8e1519",
+          "alpha": 1,
+          "filePath": "src/tokens/component/button.json5",
+          "isSource": true,
+          "$type": "color"
       }
     }
   },
@@ -4207,6 +4214,13 @@
           "filePath": "src/tokens/component/button.json5",
           "isSource": true,
           "$type": "color"
+          },
+          "light-high-contrast": {
+            "$value": "{base.color.red.7}",
+            "alpha": 1,
+            "filePath": "src/tokens/component/button.json5",
+            "isSource": true,
+            "$type": "color"
         }
       }
     }
@@ -12691,6 +12705,12 @@
         "filePath": "src/tokens/functional/color/control.json5",
         "isSource": true,
         "$type": "color"
+        },
+        "dark-high-contrast": {
+          "$value": "#ffffff",
+          "filePath": "src/tokens/functional/color/control.json5",
+          "isSource": true,
+          "$type": "color"
       }
     }
   },
@@ -12712,6 +12732,12 @@
           "$value": "{fgColor.onEmphasis}",
           "filePath": "src/tokens/functional/color/control.json5",
           "isSource": true,
+            "$type": "color"
+          },
+          "dark-high-contrast": {
+            "$value": "{fgColor.onEmphasis}",
+            "filePath": "src/tokens/functional/color/control.json5",
+            "isSource": true,
           "$type": "color"
         }
       }

/styleLint/functional/themes/dark-dimmed.json

 
+++ /home/runner/work/primitives/primitives/dist/styleLint/functional/themes/dark-dimmed.json	2025-03-26 19:05:11.091371166 +0000
@@ -3682,7 +3682,7 @@
         "$type": "color"
       },
       "dark-high-contrast": {
-          "$value": "#2f3742",
+          "$value": "#9198a1",
         "alpha": 1,
         "filePath": "src/tokens/functional/color/borderColor.json5",
         "isSource": true,
@@ -3711,7 +3711,7 @@
           "$type": "color"
         },
         "dark-high-contrast": {
-            "$value": "{base.color.neutral.6}",
+            "$value": "{base.color.neutral.9}",
           "alpha": 1,
           "filePath": "src/tokens/functional/color/borderColor.json5",
           "isSource": true,
@@ -4174,6 +4174,13 @@
         "filePath": "src/tokens/component/button.json5",
         "isSource": true,
         "$type": "color"
+        },
+        "light-high-contrast": {
+          "$value": "#922323",
+          "alpha": 1,
+          "filePath": "src/tokens/component/button.json5",
+          "isSource": true,
+          "$type": "color"
       }
     }
   },
@@ -4201,6 +4208,13 @@
           "filePath": "src/tokens/component/button.json5",
           "isSource": true,
           "$type": "color"
+          },
+          "light-high-contrast": {
+            "$value": "{base.color.red.7}",
+            "alpha": 1,
+            "filePath": "src/tokens/component/button.json5",
+            "isSource": true,
+            "$type": "color"
         }
       }
     }
@@ -12687,6 +12701,12 @@
         "filePath": "src/tokens/functional/color/control.json5",
         "isSource": true,
         "$type": "color"
+        },
+        "dark-high-contrast": {
+          "$value": "#f0f6fc",
+          "filePath": "src/tokens/functional/color/control.json5",
+          "isSource": true,
+          "$type": "color"
       }
     }
   },
@@ -12708,6 +12728,12 @@
           "$value": "{fgColor.onEmphasis}",
           "filePath": "src/tokens/functional/color/control.json5",
           "isSource": true,
+            "$type": "color"
+          },
+          "dark-high-contrast": {
+            "$value": "{fgColor.onEmphasis}",
+            "filePath": "src/tokens/functional/color/control.json5",
+            "isSource": true,
           "$type": "color"
         }
       }

/styleLint/functional/themes/dark-high-contrast.json

 
+++ /home/runner/work/primitives/primitives/dist/styleLint/functional/themes/dark-high-contrast.json	2025-03-26 19:05:16.065425493 +0000
@@ -3663,7 +3663,7 @@
   "key": "{borderColor.success.muted}"
 },
 "borderColor-translucent": {
-    "$value": "#2f3742",
+    "$value": "#9198a1",
   "$type": "color",
   "$extensions": {
     "org.primer.figma": {
@@ -3680,7 +3680,7 @@
         "$type": "color"
       },
       "dark-high-contrast": {
-          "$value": "#2f3742",
+          "$value": "#9198a1",
         "alpha": 1,
         "filePath": "src/tokens/functional/color/borderColor.json5",
         "isSource": true,
@@ -3692,7 +3692,7 @@
   "filePath": "src/tokens/functional/color/borderColor.json5",
   "isSource": true,
   "original": {
-      "$value": "{base.color.neutral.6}",
+      "$value": "{base.color.neutral.9}",
     "$type": "color",
     "$extensions": {
       "org.primer.figma": {
@@ -3709,7 +3709,7 @@
           "$type": "color"
         },
         "dark-high-contrast": {
-            "$value": "{base.color.neutral.6}",
+            "$value": "{base.color.neutral.9}",
           "alpha": 1,
           "filePath": "src/tokens/functional/color/borderColor.json5",
           "isSource": true,
@@ -4174,6 +4174,13 @@
         "filePath": "src/tokens/component/button.json5",
         "isSource": true,
         "$type": "color"
+        },
+        "light-high-contrast": {
+          "$value": "#e82a2f",
+          "alpha": 1,
+          "filePath": "src/tokens/component/button.json5",
+          "isSource": true,
+          "$type": "color"
       }
     }
   },
@@ -4202,6 +4209,13 @@
           "filePath": "src/tokens/component/button.json5",
           "isSource": true,
           "$type": "color"
+          },
+          "light-high-contrast": {
+            "$value": "{base.color.red.7}",
+            "alpha": 1,
+            "filePath": "src/tokens/component/button.json5",
+            "isSource": true,
+            "$type": "color"
         }
       }
     },
@@ -12683,7 +12697,7 @@
   "key": "{control.danger.bgColor.hover}"
 },
 "control-danger-fgColor-hover": {
-    "$value": "#ff9492",
+    "$value": "#ffffff",
   "$type": "color",
   "$extensions": {
     "org.primer.figma": {
@@ -12699,13 +12713,19 @@
         "filePath": "src/tokens/functional/color/control.json5",
         "isSource": true,
         "$type": "color"
+        },
+        "dark-high-contrast": {
+          "$value": "#ffffff",
+          "filePath": "src/tokens/functional/color/control.json5",
+          "isSource": true,
+          "$type": "color"
       }
     }
   },
   "filePath": "src/tokens/functional/color/control.json5",
   "isSource": true,
   "original": {
-      "$value": "{base.color.red.3}",
+      "$value": "{fgColor.onEmphasis}",
     "$type": "color",
     "$extensions": {
       "org.primer.figma": {
@@ -12720,6 +12740,12 @@
           "$value": "{fgColor.onEmphasis}",
           "filePath": "src/tokens/functional/color/control.json5",
           "isSource": true,
+            "$type": "color"
+          },
+          "dark-high-contrast": {
+            "$value": "{fgColor.onEmphasis}",
+            "filePath": "src/tokens/functional/color/control.json5",
+            "isSource": true,
           "$type": "color"
         }
       }

/styleLint/functional/themes/dark-tritanopia.json

 
+++ /home/runner/work/primitives/primitives/dist/styleLint/functional/themes/dark-tritanopia.json	2025-03-26 19:05:12.739389175 +0000
@@ -3688,7 +3688,7 @@
         "$type": "color"
       },
       "dark-high-contrast": {
-          "$value": "#2f3742",
+          "$value": "#9198a1",
         "alpha": 1,
         "filePath": "src/tokens/functional/color/borderColor.json5",
         "isSource": true,
@@ -3717,7 +3717,7 @@
           "$type": "color"
         },
         "dark-high-contrast": {
-            "$value": "{base.color.neutral.6}",
+            "$value": "{base.color.neutral.9}",
           "alpha": 1,
           "filePath": "src/tokens/functional/color/borderColor.json5",
           "isSource": true,
@@ -4180,6 +4180,13 @@
         "filePath": "src/tokens/component/button.json5",
         "isSource": true,
         "$type": "color"
+        },
+        "light-high-contrast": {
+          "$value": "#8e1519",
+          "alpha": 1,
+          "filePath": "src/tokens/component/button.json5",
+          "isSource": true,
+          "$type": "color"
       }
     }
   },
@@ -4207,6 +4214,13 @@
           "filePath": "src/tokens/component/button.json5",
           "isSource": true,
           "$type": "color"
+          },
+          "light-high-contrast": {
+            "$value": "{base.color.red.7}",
+            "alpha": 1,
+            "filePath": "src/tokens/component/button.json5",
+            "isSource": true,
+            "$type": "color"
         }
       }
     }
@@ -12691,6 +12705,12 @@
         "filePath": "src/tokens/functional/color/control.json5",
         "isSource": true,
         "$type": "color"
+        },
+        "dark-high-contrast": {
+          "$value": "#ffffff",
+          "filePath": "src/tokens/functional/color/control.json5",
+          "isSource": true,
+          "$type": "color"
       }
     }
   },
@@ -12712,6 +12732,12 @@
           "$value": "{fgColor.onEmphasis}",
           "filePath": "src/tokens/functional/color/control.json5",
           "isSource": true,
+            "$type": "color"
+          },
+          "dark-high-contrast": {
+            "$value": "{fgColor.onEmphasis}",
+            "filePath": "src/tokens/functional/color/control.json5",
+            "isSource": true,
           "$type": "color"
         }
       }

/styleLint/functional/themes/dark.json

 
+++ /home/runner/work/primitives/primitives/dist/styleLint/functional/themes/dark.json	2025-03-26 19:05:09.578354600 +0000
@@ -3680,7 +3680,7 @@
         "$type": "color"
       },
       "dark-high-contrast": {
-          "$value": "#2f3742",
+          "$value": "#9198a1",
         "alpha": 1,
         "filePath": "src/tokens/functional/color/borderColor.json5",
         "isSource": true,
@@ -3709,7 +3709,7 @@
           "$type": "color"
         },
         "dark-high-contrast": {
-            "$value": "{base.color.neutral.6}",
+            "$value": "{base.color.neutral.9}",
           "alpha": 1,
           "filePath": "src/tokens/functional/color/borderColor.json5",
           "isSource": true,
@@ -4172,6 +4172,13 @@
         "filePath": "src/tokens/component/button.json5",
         "isSource": true,
         "$type": "color"
+        },
+        "light-high-contrast": {
+          "$value": "#8e1519",
+          "alpha": 1,
+          "filePath": "src/tokens/component/button.json5",
+          "isSource": true,
+          "$type": "color"
       }
     }
   },
@@ -4199,6 +4206,13 @@
           "filePath": "src/tokens/component/button.json5",
           "isSource": true,
           "$type": "color"
+          },
+          "light-high-contrast": {
+            "$value": "{base.color.red.7}",
+            "alpha": 1,
+            "filePath": "src/tokens/component/button.json5",
+            "isSource": true,
+            "$type": "color"
         }
       }
     }
@@ -12683,6 +12697,12 @@
         "filePath": "src/tokens/functional/color/control.json5",
         "isSource": true,
         "$type": "color"
+        },
+        "dark-high-contrast": {
+          "$value": "#ffffff",
+          "filePath": "src/tokens/functional/color/control.json5",
+          "isSource": true,
+          "$type": "color"
       }
     }
   },
@@ -12704,6 +12724,12 @@
           "$value": "{fgColor.onEmphasis}",
           "filePath": "src/tokens/functional/color/control.json5",
           "isSource": true,
+            "$type": "color"
+          },
+          "dark-high-contrast": {
+            "$value": "{fgColor.onEmphasis}",
+            "filePath": "src/tokens/functional/color/control.json5",
+            "isSource": true,
           "$type": "color"
         }
       }

/styleLint/functional/themes/light-colorblind.json

 
+++ /home/runner/work/primitives/primitives/dist/styleLint/functional/themes/light-colorblind.json	2025-03-26 19:05:06.389319682 +0000
@@ -3668,7 +3668,7 @@
         "$type": "color"
       },
       "dark-high-contrast": {
-          "$value": "#d1d9e0",
+          "$value": "#59636e",
         "alpha": 1,
         "filePath": "src/tokens/functional/color/borderColor.json5",
         "isSource": true,
@@ -3697,7 +3697,7 @@
           "$type": "color"
         },
         "dark-high-contrast": {
-            "$value": "{base.color.neutral.6}",
+            "$value": "{base.color.neutral.9}",
           "alpha": 1,
           "filePath": "src/tokens/functional/color/borderColor.json5",
           "isSource": true,
@@ -4160,6 +4160,13 @@
         "filePath": "src/tokens/component/button.json5",
         "isSource": true,
         "$type": "color"
+        },
+        "light-high-contrast": {
+          "$value": "#82071e",
+          "alpha": 1,
+          "filePath": "src/tokens/component/button.json5",
+          "isSource": true,
+          "$type": "color"
       }
     }
   },
@@ -4187,6 +4194,13 @@
           "filePath": "src/tokens/component/button.json5",
           "isSource": true,
           "$type": "color"
+          },
+          "light-high-contrast": {
+            "$value": "{base.color.red.7}",
+            "alpha": 1,
+            "filePath": "src/tokens/component/button.json5",
+            "isSource": true,
+            "$type": "color"
         }
       }
     }
@@ -12673,6 +12687,12 @@
         "filePath": "src/tokens/functional/color/control.json5",
         "isSource": true,
         "$type": "color"
+        },
+        "dark-high-contrast": {
+          "$value": "#ffffff",
+          "filePath": "src/tokens/functional/color/control.json5",
+          "isSource": true,
+          "$type": "color"
       }
     }
   },
@@ -12694,6 +12714,12 @@
           "$value": "{fgColor.onEmphasis}",
           "filePath": "src/tokens/functional/color/control.json5",
           "isSource": true,
+            "$type": "color"
+          },
+          "dark-high-contrast": {
+            "$value": "{fgColor.onEmphasis}",
+            "filePath": "src/tokens/functional/color/control.json5",
+            "isSource": true,
           "$type": "color"
         }
       }

/styleLint/functional/themes/light-high-contrast.json

 
+++ /home/runner/work/primitives/primitives/dist/styleLint/functional/themes/light-high-contrast.json	2025-03-26 19:05:07.884336052 +0000
@@ -3664,7 +3664,7 @@
         "$type": "color"
       },
       "dark-high-contrast": {
-          "$value": "#d1d9e0",
+          "$value": "#59636e",
         "alpha": 1,
         "filePath": "src/tokens/functional/color/borderColor.json5",
         "isSource": true,
@@ -3693,7 +3693,7 @@
           "$type": "color"
         },
         "dark-high-contrast": {
-            "$value": "{base.color.neutral.6}",
+            "$value": "{base.color.neutral.9}",
           "alpha": 1,
           "filePath": "src/tokens/functional/color/borderColor.json5",
           "isSource": true,
@@ -4077,7 +4077,7 @@
   "key": "{button.danger.bgColor.rest}"
 },
 "button-danger-borderColor-active": {
-    "$value": "#013d14",
+    "$value": "#6e011a",
   "$type": "color",
   "$extensions": {
     "org.primer.figma": {
@@ -4087,7 +4087,7 @@
     },
     "org.primer.overrides": {
       "dark": {
-          "$value": "#013d14",
+          "$value": "#6e011a",
         "filePath": "src/tokens/component/button.json5",
         "isSource": true,
         "$type": "color"
@@ -4135,7 +4135,7 @@
   "key": "{button.danger.borderColor.active}"
 },
 "button-danger-borderColor-hover": {
-    "$value": "#013d14",
+    "$value": "#6e011a",
   "$type": "color",
   "$extensions": {
     "org.primer.figma": {
@@ -4156,13 +4156,21 @@
         "filePath": "src/tokens/component/button.json5",
         "isSource": true,
         "$type": "color"
+        },
+        "light-high-contrast": {
+          "$value": "#6e011a",
+          "alpha": 1,
+          "filePath": "src/tokens/component/button.json5",
+          "isSource": true,
+          "$type": "color"
       }
     }
   },
   "filePath": "src/tokens/component/button.json5",
   "isSource": true,
+    "alpha": 1,
   "original": {
-      "$value": "{button.primary.borderColor.rest}",
+      "$value": "{base.color.red.7}",
     "$type": "color",
     "$extensions": {
       "org.primer.figma": {
@@ -4183,9 +4191,17 @@
           "filePath": "src/tokens/component/button.json5",
           "isSource": true,
           "$type": "color"
+          },
+          "light-high-contrast": {
+            "$value": "{base.color.red.7}",
+            "alpha": 1,
+            "filePath": "src/tokens/component/button.json5",
+            "isSource": true,
+            "$type": "color"
         }
       }
-      }
+      },
+      "alpha": 1
   },
   "name": "button-danger-borderColor-hover",
   "attributes": {},
@@ -12673,6 +12689,12 @@
         "filePath": "src/tokens/functional/color/control.json5",
         "isSource": true,
         "$type": "color"
+        },
+        "dark-high-contrast": {
+          "$value": "#ffffff",
+          "filePath": "src/tokens/functional/color/control.json5",
+          "isSource": true,
+          "$type": "color"
       }
     }
   },
@@ -12694,6 +12716,12 @@
           "$value": "{fgColor.onEmphasis}",
           "filePath": "src/tokens/functional/color/control.json5",
           "isSource": true,
+            "$type": "color"
+          },
+          "dark-high-contrast": {
+            "$value": "{fgColor.onEmphasis}",
+            "filePath": "src/tokens/functional/color/control.json5",
+            "isSource": true,
           "$type": "color"
         }
       }

/styleLint/functional/themes/light-tritanopia.json

 
+++ /home/runner/work/primitives/primitives/dist/styleLint/functional/themes/light-tritanopia.json	2025-03-26 19:05:04.764301889 +0000
@@ -3668,7 +3668,7 @@
         "$type": "color"
       },
       "dark-high-contrast": {
-          "$value": "#d1d9e0",
+          "$value": "#59636e",
         "alpha": 1,
         "filePath": "src/tokens/functional/color/borderColor.json5",
         "isSource": true,
@@ -3697,7 +3697,7 @@
           "$type": "color"
         },
         "dark-high-contrast": {
-            "$value": "{base.color.neutral.6}",
+            "$value": "{base.color.neutral.9}",
           "alpha": 1,
           "filePath": "src/tokens/functional/color/borderColor.json5",
           "isSource": true,
@@ -4160,6 +4160,13 @@
         "filePath": "src/tokens/component/button.json5",
         "isSource": true,
         "$type": "color"
+        },
+        "light-high-contrast": {
+          "$value": "#82071e",
+          "alpha": 1,
+          "filePath": "src/tokens/component/button.json5",
+          "isSource": true,
+          "$type": "color"
       }
     }
   },
@@ -4187,6 +4194,13 @@
           "filePath": "src/tokens/component/button.json5",
           "isSource": true,
           "$type": "color"
+          },
+          "light-high-contrast": {
+            "$value": "{base.color.red.7}",
+            "alpha": 1,
+            "filePath": "src/tokens/component/button.json5",
+            "isSource": true,
+            "$type": "color"
         }
       }
     }
@@ -12673,6 +12687,12 @@
         "filePath": "src/tokens/functional/color/control.json5",
         "isSource": true,
         "$type": "color"
+        },
+        "dark-high-contrast": {
+          "$value": "#ffffff",
+          "filePath": "src/tokens/functional/color/control.json5",
+          "isSource": true,
+          "$type": "color"
       }
     }
   },
@@ -12694,6 +12714,12 @@
           "$value": "{fgColor.onEmphasis}",
           "filePath": "src/tokens/functional/color/control.json5",
           "isSource": true,
+            "$type": "color"
+          },
+          "dark-high-contrast": {
+            "$value": "{fgColor.onEmphasis}",
+            "filePath": "src/tokens/functional/color/control.json5",
+            "isSource": true,
           "$type": "color"
         }
       }

/styleLint/functional/themes/light.json

 
+++ /home/runner/work/primitives/primitives/dist/styleLint/functional/themes/light.json	2025-03-26 19:05:03.162284353 +0000
@@ -3664,7 +3664,7 @@
         "$type": "color"
       },
       "dark-high-contrast": {
-          "$value": "#d1d9e0",
+          "$value": "#59636e",
         "alpha": 1,
         "filePath": "src/tokens/functional/color/borderColor.json5",
         "isSource": true,
@@ -3693,7 +3693,7 @@
           "$type": "color"
         },
         "dark-high-contrast": {
-            "$value": "{base.color.neutral.6}",
+            "$value": "{base.color.neutral.9}",
           "alpha": 1,
           "filePath": "src/tokens/functional/color/borderColor.json5",
           "isSource": true,
@@ -4156,6 +4156,13 @@
         "filePath": "src/tokens/component/button.json5",
         "isSource": true,
         "$type": "color"
+        },
+        "light-high-contrast": {
+          "$value": "#82071e",
+          "alpha": 1,
+          "filePath": "src/tokens/component/button.json5",
+          "isSource": true,
+          "$type": "color"
       }
     }
   },
@@ -4183,6 +4190,13 @@
           "filePath": "src/tokens/component/button.json5",
           "isSource": true,
           "$type": "color"
+          },
+          "light-high-contrast": {
+            "$value": "{base.color.red.7}",
+            "alpha": 1,
+            "filePath": "src/tokens/component/button.json5",
+            "isSource": true,
+            "$type": "color"
         }
       }
     }
@@ -12669,6 +12683,12 @@
         "filePath": "src/tokens/functional/color/control.json5",
         "isSource": true,
         "$type": "color"
+        },
+        "dark-high-contrast": {
+          "$value": "#ffffff",
+          "filePath": "src/tokens/functional/color/control.json5",
+          "isSource": true,
+          "$type": "color"
       }
     }
   },
@@ -12690,6 +12710,12 @@
           "$value": "{fgColor.onEmphasis}",
           "filePath": "src/tokens/functional/color/control.json5",
           "isSource": true,
+            "$type": "color"
+          },
+          "dark-high-contrast": {
+            "$value": "{fgColor.onEmphasis}",
+            "filePath": "src/tokens/functional/color/control.json5",
+            "isSource": true,
           "$type": "color"
         }
       }

@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2025 •
edited
Loading

Design Token Diff (Figma)

/figma/themes/dark-high-contrast.json

 
+++ /home/runner/work/primitives/primitives/dist/figma/themes/dark-high-contrast.json	2025-03-26 19:05:23.953511701 +0000
@@ -6399,15 +6399,15 @@
 {
   "name": "borderColor/translucent",
   "value": {
-      "r": 0.1843137254901961,
-      "g": 0.21568627450980393,
-      "b": 0.25882352941176473,
+      "r": 0.5686274509803921,
+      "g": 0.596078431372549,
+      "b": 0.6313725490196078,
     "a": 1
   },
   "type": "COLOR",
   "alpha": 1,
   "refId": "mode/borderColor/translucent",
-    "reference": "base/color/dark/base/color/neutral/6",
+    "reference": "base/color/dark/base/color/neutral/9",
   "collection": "mode",
   "mode": "dark high contrast",
   "group": "semantic",
@@ -7239,13 +7239,13 @@
   "name": "control/danger/fgColor/hover",
   "value": {
     "r": 1,
-      "g": 0.5803921568627451,
-      "b": 0.5725490196078431,
+      "g": 1,
+      "b": 1,
     "a": 1
   },
   "type": "COLOR",
   "refId": "mode/control/danger/fgColor/hover",
-    "reference": "base/color/dark-high-contrast/base/color/red/3",
+    "reference": "mode/fgColor/onEmphasis",
   "collection": "mode",
   "mode": "dark high contrast",
   "group": "component",

/figma/themes/light-high-contrast.json

 
+++ /home/runner/work/primitives/primitives/dist/figma/themes/light-high-contrast.json	2025-03-26 19:05:21.602485989 +0000
@@ -2064,14 +2064,15 @@
 {
   "name": "button/danger/borderColor/hover",
   "value": {
-      "r": 0.00392156862745098,
-      "g": 0.23921568627450981,
-      "b": 0.0784313725490196,
+      "r": 0.43137254901960786,
+      "g": 0.00392156862745098,
+      "b": 0.10196078431372549,
     "a": 1
   },
   "type": "COLOR",
+    "alpha": 1,
   "refId": "mode/button/danger/borderColor/hover",
-    "reference": "mode/button/primary/borderColor/rest",
+    "reference": "base/color/light-high-contrast/base/color/red/7",
   "collection": "mode",
   "mode": "light high contrast",
   "group": "component (internal)",
@@ -2080,9 +2081,9 @@
 {
   "name": "button/danger/borderColor/active",
   "value": {
-      "r": 0.00392156862745098,
-      "g": 0.23921568627450981,
-      "b": 0.0784313725490196,
+      "r": 0.43137254901960786,
+      "g": 0.00392156862745098,
+      "b": 0.10196078431372549,
     "a": 1
   },
   "type": "COLOR",

@github-actions github-actions bot temporarily deployed to Preview (Storybook) March 26, 2025 18:45 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) March 26, 2025 18:46 Inactive
@github-actions github-actions bot removed the update snapshots Update visual regression test snapshots label Mar 26, 2025
@primer primer bot temporarily deployed to github-pages March 26, 2025 19:06 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) March 26, 2025 19:06 Inactive
@langermank langermank marked this pull request as ready for review March 26, 2025 21:58
@langermank langermank requested review from a team as code owners March 26, 2025 21:58
@langermank langermank merged commit 72cf27d into main Mar 26, 2025
27 checks passed
@langermank langermank deleted the bug-fixes branch March 26, 2025 21:58
@primer primer bot mentioned this pull request Mar 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukasoppermann lukasoppermann Awaiting requested review from lukasoppermann lukasoppermann is a code owner automatically assigned from primer/css-reviewers

@francinelucca francinelucca Awaiting requested review from francinelucca francinelucca is a code owner automatically assigned from primer/engineer-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@langermank