Determanistic url params#27
Open
matt-oakes wants to merge 1 commit intoprismicio-community:masterfrom
Open
Conversation
Author
|
Is there any update on this? Currently we're using a forked version of this library to work around this issue. |
Contributor
|
Hi, I'm fine for the deterministic order, but I don't want to change milliseconds to seconds because it would break existing things and be inconsistent with API in other languages. Could you separate them? |
The URL parameters should be deterministic as the full URL is used as the key for caching. If the non-ordered dictionary is used the caching will miss even when a value has been stored.
matt-oakes
force-pushed
the
determanistic_url_params
branch
from
341de74 to
0737a59
Compare
Author
|
That should be just the URL change now. Once this is merged in, can you push a release please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The URL parameters should be deterministic as the full URL is used as the key for caching. If the non-ordered dictionary is used the caching will miss even when a value has been stored.
I've also converted the max age from what I assume is milliseconds into seconds, which Python requires.
The Prismic API is sending very high expiry times (10 years) for articles, which makes it seem like it's using milliseconds rather than seconds. Some caching libraries (including AppEngine Memcache) sees this 10 year value as an error and refuses to store or retrieve the cached value.