Merged
Conversation
landinjm
force-pushed
the
clangtidy_CI
branch
from
6117dcc to
fde4e14
Compare
* Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Update parameters.prm added "set vtk file type" to select what type of vtk file to read * This is the 64X64 2D rectilinear mesh * Updated Body.hh for switch between RL and US mesh * Instructions on how to create a rectilinear mesh using dream3d and convert it * autoformatting * fixing warnings --------- Co-authored-by: Jason Landini <landinjm@umich.edu>
…. Ideally, we should include these, but it is too much to fix right now.
landinjm
force-pushed
the
clangtidy_CI
branch
from
ccbd364 to
8c005cd
Compare
Contributor
Author
|
This should be pushed since new PRs are going to outpace the rate at which I can squash these errors. It's better to have something and work towards fixing it than constantly having to fix merge issues and new tidy errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added clang-tidy CI. Still working out some kinks in what checks we should include.
Right now the tests fail because the code hasn't been updated to follow the clang-tidy checks.
Closes #248