Merged
Conversation
landinjm
force-pushed
the
nonlinearity_unit_test
branch
from
a9808fb to
d929714
Compare
landinjm
force-pushed
the
nonlinearity_unit_test
branch
from
d8c51ce to
7d82093
Compare
landinjm
added a commit
that referenced
this pull request
Jan 27, 2025
* unit test for nonlinear variables * changing application implementation to a derived class too * typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed up the virtual inheritance for the
variableAttributeLoaderand added unit tests for nonlinear criterion.I think I got most of the potential combinations. I didn't write any that capture errors.
Note that the nonlinear criterion becomes tricky for the steady-state Cahn-Hilliard equation because of the circular dependence.
Closes #338.
Checklist
Miscellaneous items that may need to be done when making a PR: